Bug 257469 - pf: yesterday changes broke sysutils/pftop with 'DIOCGETSTATUS: Permission denied'
Summary: pf: yesterday changes broke sysutils/pftop with 'DIOCGETSTATUS: Permission de...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 13.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Kristof Provost
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-07-28 08:41 UTC by Raúl
Modified: 2021-07-31 13:04 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raúl 2021-07-28 08:41:29 UTC
On stable/13-7d226e964: Tue Jul 27 15:03:30 CEST 2021,
'pftop' shows '> Error Reading status (DIOCGETSTATUS): Permission denied'.
Comment 1 Herbert J. Skuhra 2021-07-28 08:50:05 UTC
Rebuild the port!
Comment 2 Raúl 2021-07-28 08:56:57 UTC
(In reply to Herbert J. Skuhra from comment #1)

You were right, working after rebuilding the port.
Thanks!.
Comment 3 Kristof Provost freebsd_committer 2021-07-28 09:01:15 UTC
Yeah, rebuilding the port would work, because I accidentally changed the size of the pf_status struct. That wasn't supposed to happen. I'll fix that, but that does mean you're going to have to rebuild the port again (or revert to the pkg version) after it's fixed.
Comment 4 Raúl 2021-07-28 09:08:01 UTC
(In reply to Kristof Provost from comment #3)

That's what I though, an ABI problem on STABLE.
I'll reinstall from pkg, no worries. Thanks a lot!.
Comment 5 commit-hook freebsd_committer 2021-07-28 12:22:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=da8d8b22e69c72f1d001d55b5eff5acbb0265cfc

commit da8d8b22e69c72f1d001d55b5eff5acbb0265cfc
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-07-28 09:24:44 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-07-28 10:16:33 +0000

    pf: fix ABI breakage

    The introduction of synproxy support changed the size of struct
    pf_status, which in turn broke the userspace ABI.

    Revert the relevant change. More work is needed on the synproxy code to
    keep and expose the counters, but in the mean time this restores the
    ABI.

    PR:             257469
    MFC after:      3 days
    Sponsored by:   Modirum MDPay

 sys/netpfil/pf/pf.h            | 3 +--
 sys/netpfil/pf/pf_syncookies.c | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)
Comment 6 commit-hook freebsd_committer 2021-07-31 13:04:21 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=bca83d9e7f5b7faa925ca7edde6129f57adcd09d

commit bca83d9e7f5b7faa925ca7edde6129f57adcd09d
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-07-28 09:24:44 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-07-31 09:14:44 +0000

    pf: fix ABI breakage

    The introduction of synproxy support changed the size of struct
    pf_status, which in turn broke the userspace ABI.

    Revert the relevant change. More work is needed on the synproxy code to
    keep and expose the counters, but in the mean time this restores the
    ABI.

    PR:             257469
    MFC after:      3 days
    Sponsored by:   Modirum MDPay

    (cherry picked from commit da8d8b22e69c72f1d001d55b5eff5acbb0265cfc)

 sys/netpfil/pf/pf.h            | 3 +--
 sys/netpfil/pf/pf_syncookies.c | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)
Comment 7 commit-hook freebsd_committer 2021-07-31 13:04:23 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=adde304e53488bec9ec5ba4d589f365e9e0c4aad

commit adde304e53488bec9ec5ba4d589f365e9e0c4aad
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2021-07-28 09:24:44 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2021-07-31 08:12:20 +0000

    pf: fix ABI breakage

    The introduction of synproxy support changed the size of struct
    pf_status, which in turn broke the userspace ABI.

    Revert the relevant change. More work is needed on the synproxy code to
    keep and expose the counters, but in the mean time this restores the
    ABI.

    PR:             257469
    MFC after:      3 days
    Sponsored by:   Modirum MDPay

    (cherry picked from commit da8d8b22e69c72f1d001d55b5eff5acbb0265cfc)

 sys/netpfil/pf/pf.h            | 3 +--
 sys/netpfil/pf/pf_syncookies.c | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)