Bug 257520 - audio/fossmixer: Fix illegal instruction error on some hosts
Summary: audio/fossmixer: Fix illegal instruction error on some hosts
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks: 253235
  Show dependency treegraph
 
Reported: 2021-07-31 16:01 UTC by Jani Salonen
Modified: 2021-08-01 14:28 UTC (History)
2 users (show)

See Also:


Attachments
Fix crash caused by illegal instruction error. (3.86 KB, application/x-shellscript)
2021-07-31 16:01 UTC, Jani Salonen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jani Salonen 2021-07-31 16:01:52 UTC
Created attachment 226821 [details]
Fix crash caused by illegal instruction error.

configure script includes some non-wanted flags for compiler by accident, which causes program to crash on some hosts. Attached patch will fix this.
Comment 1 Li-Wen Hsu freebsd_committer 2021-07-31 16:17:22 UTC
Shar is not very easy to be applied and it's removed from the recommended ways of submitting ports patches. Is is possible for you to send a patch generated by `git format-patch` or `git diff`? Thanks!
Comment 2 Alexey Dokuchaev freebsd_committer 2021-08-01 02:47:45 UTC
It's okay, Jani, no need to resend anything, the diff is pretty clear, I'll handle it.
Comment 3 commit-hook freebsd_committer 2021-08-01 14:24:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b8e8a959d729468d50b9399483bc6b6ba47cfac4

commit b8e8a959d729468d50b9399483bc6b6ba47cfac4
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-08-01 14:20:22 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-08-01 14:23:13 +0000

    audio/fossmixer: fix illegal instruction error on some hosts

    Previously, configure script was passing certain optimization options
    by default; now it is protected by --enable-native switch which users
    have to specify explicitly:

      -C_FLAGS=$C_FLAGS" -O3 -ffast-math `/bin/sh ./build/opt.sh \"$CC\" -march=native`"
      +C_FLAGS=$C_FLAGS" -O2"

    Take one step further and replace -O2 with our default CFLAGS which are
    essentially the same, but safer (https://blog.regehr.org/archives/1307).

    We must, however, force -msse2 on i386 for the build to succeed there;
    other architectures might or might not need similar treatment as well.

    PR:             257520
    Submitted by:   maintainer (who is also upstream author)

 audio/fossmixer/Makefile | 6 ++++--
 audio/fossmixer/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 5 deletions(-)