I was just finishing testing this patch when #255547, so adding wen@ (committer) and Sascha (reporter) to CC. Twisted released again in the past few days, version 21.7.0. I ran all ports tests against Twisted 20.3.0 (the version in ports until last week) and against Twisted 21.7.0, the latest version. The results do not vary significantly since Twisted is quite good at backwards compatibility. I also fixed the way to run Twisted tests from the port, hopefully we can improve testing on FreeBSD upstream. Can we merge this patch? With it I also volunteer to adopt devel/py-twisted so it is kept up to date in the ports tree. See the produced outputs (*): https://evilham.com/twisted_tests_20.3.0.log https://evilham.com/twisted_tests_21.7.0.log And the resulting diff: https://evilham.com/twisted_tests.diff (*): txredisapi is missing since the tests take a very long time to fail in either Twisted version. This kind of tree-wide testing takes a very long time, I am currently using a script [1] inside a jail, are there better ways? [1]: https://git.sr.ht/~evilham/freebsd-ports/tree/evilham/item/.builds/run-dependent-ports-tests
Created attachment 226829 [details] devel/py-twisted: update to 21.7.0
Grr, sorry, I meant to reference bug 255547
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5f94563da5d94be233577ec6a068b22bb0507cc7 commit 5f94563da5d94be233577ec6a068b22bb0507cc7 Author: Wen Heping <wen@FreeBSD.org> AuthorDate: 2021-08-01 10:14:57 +0000 Commit: Wen Heping <wen@FreeBSD.org> CommitDate: 2021-08-01 10:14:57 +0000 devel/py-twisted: Update to 21.7.0 PR: 257526 Reported by: contact@evilham.com devel/py-twisted/Makefile | 8 ++++++-- devel/py-twisted/distinfo | 6 +++--- 2 files changed, 9 insertions(+), 5 deletions(-)
(In reply to Evilham from comment #1) I committed the update of py-twisted, but I did not commit the reset of maintainer. Because we do not reset maintainer of a port which is maintained by a group of people(python@). Thank your contributions ! wen
For reference: I'm +1 on offering/pass MAINTAINER'ship to motivated contributors, as long as complete change proposals and QA are done