Bug 257528 - databases/tdb: Update to 1.4.7 and tweak Makefile
Summary: databases/tdb: Update to 1.4.7 and tweak Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-01 11:35 UTC by Daniel Engberg
Modified: 2022-07-30 00:20 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (timur)


Attachments
Patch for tdb (5.43 KB, patch)
2021-08-01 11:35 UTC, Daniel Engberg
no flags Details | Diff
Patch for tdb v2 (5.45 KB, patch)
2021-08-01 11:52 UTC, Daniel Engberg
no flags Details | Diff
Patch for tdb v3 (5.58 KB, patch)
2022-06-10 07:49 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-08-01 11:35:24 UTC
Created attachment 226832 [details]
Patch for tdb

Update tdb to 1.4.5
PORTVERSION --> DISTVERSION
Remove tests for multiprocessing python pacakge/module, all versions in tree ships it
Remove very old CONFLITCS entry
Utilize ports framework to remove several if statements
Drop color output settings

Compile and tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-08-01 11:52:29 UTC
Created attachment 226833 [details]
Patch for tdb v2

Add missing dependency for PYTHON variant when using Poudriere
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2021-09-16 11:53:41 UTC
Friendly ping
Comment 3 ml 2022-04-26 06:10:03 UTC
Meanwhile, 1.4.6 is out (and is required for Samba 4.16).
Apparently no changes are required beyond DISTVERSION and distinfo.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2022-06-10 07:49:57 UTC
Created attachment 234595 [details]
Patch for tdb v3

Update tdb to 1.4.7

Unfortunately upstream doesn't seem to provide release/change notes
https://github.com/samba-team/samba/commits/master/lib/tdb

make test fails due to out of memory on my VM with 6Gb of RAM

It would be nice if someone would run it on a box with more RAM to see if it still fails
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2022-06-19 12:45:29 UTC
(In reply to Daniel Engberg from comment #4)

make test run see

https://people.freebsd.org/~pi/logs/tdb-make-test.txt

looks fine.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-06-19 13:16:17 UTC
(In reply to Kurt Jaeger from comment #5)
Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-07-30 00:08:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=63907c9a751afd4ae471d082c731c5f738d07c56

commit 63907c9a751afd4ae471d082c731c5f738d07c56
Author:     Timur I. Bakeyev <timur@FreeBSD.org>
AuthorDate: 2022-07-29 23:51:37 +0000
Commit:     Timur I. Bakeyev <timur@FreeBSD.org>
CommitDate: 2022-07-30 00:08:02 +0000

    databases/tdb: Upgrade 1.4.3 to 1.4.7.

    PR:             257528

 databases/tdb/Makefile        | 169 ++++++++++++++++--------------------------
 databases/tdb/distinfo        |   6 +-
 databases/tdb/pkg-plist (new) |  14 ++++
 3 files changed, 79 insertions(+), 110 deletions(-)
Comment 8 Timur I. Bakeyev freebsd_committer freebsd_triage 2022-07-30 00:13:26 UTC
(In reply to Daniel Engberg from comment #4)

Hi, Daniel!

Sorry for a long silence...

I've updated port according to your changes with some tweaks - preserving MANPAGES knob, removing colors(they are nasty when you need to compare multiple logs done via script) and leave a PKGCONFIGDIR variable.

The tests are successful(for the PYTHON version).

Thank you so much for the provided patches and testing you done!

With regards,
Timur.