Bug 257531 - Incorrect efi_var_set fn definition in efirt(9) manpage
Summary: Incorrect efi_var_set fn definition in efirt(9) manpage
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guangyuan Yang
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2021-08-01 13:30 UTC by Lakshman
Modified: 2021-11-05 05:04 UTC (History)
3 users (show)

See Also:

Attachments
fix efirt.9 manpage (567 bytes, patch)
2021-08-01 13:30 UTC, Lakshman 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshman 2021-08-01 13:30:16 UTC 
Created attachment 226842 [details]
fix efirt.9 manpage

I'm using freebsd 12. I found a manual bug in src/share/man/man9/efirt.9

The function description in efirt.9:
     int
     efi_var_set(uint16_t *name, struct	uuid *vendor, uint32_t *attrib,
	   size_t *datasize, void *data);

is different from function defined in sys/sys/efi.h

    int efi_var_set(uint16_t *name, struct uuid *vendor, uint32_t attrib,
        size_t datasize, void *data);

Attached patch to fix the efirt.9 manpage
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-11-02 07:19:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=2fe85640b2a3bf5c377dd180e40cd3d6e1a4f1f4

commit 2fe85640b2a3bf5c377dd180e40cd3d6e1a4f1f4
Author:     Lakshman <lakshman.94@outlook.com>
AuthorDate: 2021-11-02 07:17:38 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-11-02 07:17:38 +0000

    efirt(9): Correct efi_var_set definition in the manpage

    PR:             257531
    MFC after:      3 days

 share/man/man9/efirt.9 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-11-05 05:01:26 UTC 
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=3530ba8cc1e7c601e01cf1d49f7943f421844745

commit 3530ba8cc1e7c601e01cf1d49f7943f421844745
Author:     Lakshman <lakshman.94@outlook.com>
AuthorDate: 2021-11-02 07:17:38 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-11-05 04:59:54 +0000

    efirt(9): Correct efi_var_set definition in the manpage

    PR:             257531

    (cherry picked from commit 2fe85640b2a3bf5c377dd180e40cd3d6e1a4f1f4)

 share/man/man9/efirt.9 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)