Bug 257546 - security/cfv: reinstate port as it now builds with python 3.5+
Summary: security/cfv: reinstate port as it now builds with python 3.5+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-01 22:13 UTC by Terry Kennedy
Modified: 2021-08-02 16:37 UTC (History)
2 users (show)

See Also:


Attachments
Full contents of security/cfv port (1.07 KB, application/x-compressed)
2021-08-01 22:13 UTC, Terry Kennedy
no flags Details
Updated Makefile (626 bytes, text/plain)
2021-08-02 03:21 UTC, Li-Wen Hsu
no flags Details
Updagted distinfo (192 bytes, text/plain)
2021-08-02 03:21 UTC, Li-Wen Hsu
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Kennedy 2021-08-01 22:13:29 UTC
Created attachment 226865 [details]
Full contents of security/cfv port

The security/cfv port was deprecated and eventually removed in r524262 as it depended on the obsolete python27 port. Further, at that time upstream was moribund with no sign of ever releasing a version that supported Python 3+.

Fortunately, that has changed - the master site has been changed to GitHub and the codebase is again under active development. At this time the test suite passes with no errors (tested with lang/python38. should work with python3.5+):

>>> testing...
...
>>> tests finished:  ok: 3168  failed: 0
>>> testing without mmap...
...
>>> tests finished:  ok: 3168  failed: 0

I have written a new port Makefile and updated pkg-descr and distinfo. The port is now flavorized. A tarball is attached to this PR (full files instead of diffs as the old port was removed).

Additionally, MOVED needs to be updated to remove the reference to security/cfv:

--- MOVED.bak   2021-08-01 17:31:03.782038000 -0400
+++ MOVED       2021-08-01 18:06:57.530370000 -0400
@@ -13857,7 +13857,6 @@
 science/py-pyteomics.biolccc||2020-01-27|Has expired: Unmaintained, uses EOLed python27
 science/pycdf||2020-01-27|Has expired: Unmaintained, uses EOLed python27
 security/blindelephant||2020-01-27|Has expired: Unmaintained, uses EOLed python27
-security/cfv||2020-01-27|Has expired: Unmaintained, uses EOLed python27
 security/fsh||2020-01-27|Has expired: Unmaintained, uses EOLed python27
 security/gcipher||2020-01-27|Has expired: Unmaintained, uses EOLed python27
 security/kedpm||2020-01-27|Has expired: Unmaintained, uses EOLed python27

Lastly, since the port has had no maintainer since rezny@ turned in his maintainership, I volunteer to maintain it as I follow upstream's development.
Comment 1 Li-Wen Hsu freebsd_committer 2021-08-02 00:20:48 UTC
(In reply to Terry Kennedy from comment #0)
Thanks for the patch.  Although this is reinstating a removed port, we usually don't add a port with placeholder maintainer, ports@.  Do you want to maintain this port to let it be taken care of?
Comment 2 Terry Kennedy 2021-08-02 02:21:15 UTC
(In reply to Li-Wen Hsu from comment #1)

Yes, that would be fine. You can use my Bugzilla email for the maintainer contact.

Thanks!
Comment 3 Li-Wen Hsu freebsd_committer 2021-08-02 03:21:27 UTC
Created attachment 226867 [details]
Updated Makefile
Comment 4 Li-Wen Hsu freebsd_committer 2021-08-02 03:21:44 UTC
Created attachment 226868 [details]
Updagted distinfo
Comment 5 Li-Wen Hsu freebsd_committer 2021-08-02 03:25:28 UTC
I did some adjustments to Makefile:

- Use DISTVERSION=3.0.0.dev0 as this is development release and this gives port version as 3.0.0.d0. It will avoid use of PORTEPOCH when 3.0.0 release. (Result of `pkg version -t 3.0.0.d0 3.0.0` is '<')
- Remove definitions that are the same with default values
- Add do-test target
- Set MMAINTAINER

Please check. Thanks.
Comment 6 Terry Kennedy 2021-08-02 05:10:20 UTC
(In reply to Li-Wen Hsu from comment #5)

Looks good, thanks!
Comment 7 commit-hook freebsd_committer 2021-08-02 16:37:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0377086a1f58526c3026ae470cd8191838b4c1f9

commit 0377086a1f58526c3026ae470cd8191838b4c1f9
Author:     Terry Kennedy <terry-freebsd@glaver.org>
AuthorDate: 2021-08-02 16:36:24 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-08-02 16:36:24 +0000

    security/cfv: Reinstate and update to 3.0.0.dev0

    PR:             257546

 MOVED                        |  1 -
 security/Makefile            |  1 +
 security/cfv/Makefile (new)  | 28 ++++++++++++++++++++++++++++
 security/cfv/distinfo (new)  |  3 +++
 security/cfv/pkg-descr (new) | 15 +++++++++++++++
 5 files changed, 47 insertions(+), 1 deletion(-)