Bug 257565 - editors/vim: environment contamination from libcanberra
Summary: editors/vim: environment contamination from libcanberra
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-02 15:56 UTC by Philipp Ost
Modified: 2021-08-02 22:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (adamw)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-08-02 15:56:34 UTC
vim picks up libcanberra if present on the system, but it is not declared as a dependency:

====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/vim is linked to /usr/local/lib/libcanberra.so.0 from audio/libcanberra but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libcanberra.so:audio/libcanberra
Notice: Please install sysutils/rubygem-bundler for additional Gemfile-checks


This has been an issue in the past, see Bug 245460.
Comment 1 Adam Weinberger freebsd_committer 2021-08-02 22:25:35 UTC
It looks like that got removed when libgnomeui was purged. I don't think any of the available options should bring it in, so it should be safe to disable it unconditionally.
Comment 2 commit-hook freebsd_committer 2021-08-02 22:36:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6cfa70cdefcc68a5ff8afb9469c643a91cc25273

commit 6cfa70cdefcc68a5ff8afb9469c643a91cc25273
Author:     Adam Weinberger <adamw@FreeBSD.org>
AuthorDate: 2021-08-02 22:32:55 +0000
Commit:     Adam Weinberger <adamw@FreeBSD.org>
CommitDate: 2021-08-02 22:35:45 +0000

    editors/vim: Explicitly disable libcanberra support

    Vim will link against libcanberra if it's installed. It really doesn't
    serve any particular purpose for a text editor, so it makes sense for
    us to just disable it explicitly.

    This change existed before, but was hidden in the GNOME option and got
    removed when libgnomeui was purged.

    PR:             257565
    Reported by:    Philipp Ost

 editors/vim/Makefile | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Comment 3 Adam Weinberger freebsd_committer 2021-08-02 22:39:28 UTC
Thanks for submitting this, Philipp.