Bug 257579 - audio/pd: Fix build on FreeBSD 13+, NLS support, fix portlint warnings
Summary: audio/pd: Fix build on FreeBSD 13+, NLS support, fix portlint warnings
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Robert Clausecker
URL:
Keywords: needs-qa
Depends on:
Blocks: 261883
  Show dependency treegraph
 
Reported: 2021-08-03 03:06 UTC by Timothy Beyer
Modified: 2023-05-12 03:36 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (acm)
koobs: merge-quarterly?


Attachments
patch-audio_pd-freebsd13.diff (1.46 KB, patch)
2021-08-03 03:06 UTC, Timothy Beyer
no flags Details | Diff
[PATCH] fix error glist_reloadingabstraction (1.92 KB, patch)
2022-02-09 14:42 UTC, Timothy Beyer
no flags Details | Diff
fix error glist_reloadingabstraction, correct license, add NLS support (2.04 KB, patch)
2022-02-11 08:48 UTC, Timothy Beyer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Beyer 2021-08-03 03:06:31 UTC
Created attachment 226900 [details]
patch-audio_pd-freebsd13.diff

This patch fixes the build on FreeBSD 13+, and adds a subset of more conservative improvements from my MIDI patch to audio/pd, in case that is easier to apply.
Comment 1 Timothy Beyer 2021-08-03 03:07:52 UTC
Just for reference, the updated PR for midi device support patch to audio/pd is on the following URL, just for reference:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252188
Comment 2 Timothy Beyer 2021-08-03 03:10:20 UTC
just corrected the title of this PR, my apologies for the confusion that this may have caused.  The title also notes that this patch adds NLS support as well, which is a pretty small change to the port overall.
Comment 3 Timothy Beyer 2022-02-09 14:42:57 UTC
Created attachment 231682 [details]
[PATCH] fix error glist_reloadingabstraction

Although the prior patch worked fine as far as I know, I have updated the patch again with more cleanups, and it uses git format-patch format now.

I now request to become the new maintainer of audio/pd, if the prior maintainer is okay with such a change, or if committers allow to do so, but audio/pd has been broken on FreeBSD 13 for months and months broken on FreeBSD 13, so someone needs to approve fixes to the port.

If the existing maintainer responds, and wishes to continue being maintainer, then that is fine with me, but multiple patches have been submitted to fix issues for a really long time, without a response from the maintainer.

I would recommend my patch that adds MIDI support as well (I'm going to update it to this new format and with the newest fixes as well shortly, and will repost the link accordingly)
Comment 4 Timothy Beyer 2022-02-09 15:10:17 UTC
Now that I have updated the latest patch, I recommend https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252188 instead of this PR.
Comment 5 Timothy Beyer 2022-02-11 08:48:10 UTC
Created attachment 231745 [details]
fix error glist_reloadingabstraction, correct license, add NLS support

Same as previous patch, but bump PORTREVISION, and correct license

Notes on license:

  *  expr~ was no longer LGPL as of 2016-03-20, months before this release of pd

  *  the author also re-licensed the standalone library to BSD on their own website: http://yadegari.org/expr/expr.html

As noted previously, the patch also including MIDI support is a superset of this and is still recommended: 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252188
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2023-04-17 23:29:43 UTC
I'll go ahead and commit the patch from bug #252188 instead.
Comment 7 Timothy Beyer 2023-05-12 03:36:37 UTC
(In reply to Robert Clausecker from comment #6)

Thank you so much! I apologize for the embedded portmidi, although that's currently how upstream wants it to be set up, as their variant has a number of differences.

I have on my github, something like 20 or so externals for PD that I've ported over the past 2-3 years, and once I get a newer version more thoroughly tested and confirm more as working, I can update up to .5x with the more stable of those extensions, although I don't want to increase the burden on committers too much, since some of them require massive amounts of testing, especially vst, ladspa, and lv2 related externals.