Bug 257604 - graphics/libnsgif: respect CC
Summary: graphics/libnsgif: respect CC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
Keywords: patch
Depends on:
Reported: 2021-08-04 05:56 UTC by Evgeniy Khramtsov
Modified: 2021-08-08 12:04 UTC (History)
0 users

See Also:
nc: maintainer-feedback+
evgeniy: maintainer-feedback?

v1 (use "git am") (904 bytes, patch)
2021-08-04 05:56 UTC, Evgeniy Khramtsov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Evgeniy Khramtsov 2021-08-08 11:58:56 UTC
Steps to reproduce: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257622#c5

devel/netsurf-buildsystem has "BUILD_CC?=" in its files, and the ports using it are affected. See my PRs.

Also https://docs.freebsd.org/en/books/porters-handbook/porting-dads/#dads-cc
Comment 2 Neel Chauhan freebsd_committer 2021-08-08 12:00:12 UTC
LGTM. Sorry for the delay.
Comment 3 Neel Chauhan freebsd_committer 2021-08-08 12:02:05 UTC
Comment 4 commit-hook freebsd_committer 2021-08-08 12:04:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a1da0a1c27a986fa004f6f945a4bf1d4d2a1d783

commit a1da0a1c27a986fa004f6f945a4bf1d4d2a1d783
Author:     Evgeniy Khramtsov <evgeniy@khramtsov.org>
AuthorDate: 2021-08-08 12:01:30 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2021-08-08 12:01:30 +0000

    graphics/libnsgif: respect CC in MAKE_ENV

    PR:     257604

 graphics/libnsgif/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)