Created attachment 226964 [details] diff
Hi, Can you add LICENSE_FILE entry, have a look if we can enable unit tests ("make check" in upstream and "make test" for the port) and optionally (recommened by Porters Handbook) update PORTVERSION to DISTVERSION? Best regards, Daniel
Created attachment 226967 [details] Improved diff according to suggestions
(In reply to Daniel Engberg from comment #1) Thanks for the insights. Added a new patch with the suggested additions, except the testing part, which will take more time.
Thanks for your patch, looks good so far!
Hi, Any progress on the remaining part? Best regards, Daniel
Hi, Fails on 11.4-RELEASE, 12.2-RELEASE and 13-STABLE (log from 13-RELEASE) --- stackvma.o --- In file included from stackvma.c:38: ./stackvma.h:31:21: error: invalid token at start of a preprocessor expression #if STACK_DIRECTION < 0 ^ ./stackvma.h:38:21: error: invalid token at start of a preprocessor expression #if STACK_DIRECTION > 0 ^ --- sigsegv.o --- In file included from sigsegv.c:746: ./stackvma.h:31:21: error: invalid token at start of a preprocessor expression #if STACK_DIRECTION < 0 ^ ./stackvma.h:38:21: error: invalid token at start of a preprocessor expression #if STACK_DIRECTION > 0 ^ sigsegv.c:972:26: error: invalid token at start of a preprocessor expression # if STACK_DIRECTION < 0 ^ sigsegv.c:979:29: error: no member named 'is_near_this' in 'struct vma_struct' : vma.is_near_this (addr, &vma)) ~~~ ^
err, 13-RELEASE --> 13-STABLE
(In reply to Daniel Engberg from comment #6) Thanks for the assistance. Obviously it stems from libsigsegv, I'll have to set up some VM with the reported affected versions and see what I can do.
I can build it on 12.2-i386 system. wen
Still broken on amd64 unfortunately
Haven't had time to look at this. Now, maybe it looks like a non-solution, but do you guys think it would make sense to postpone the update of this port? Until when, I don't know. Also, it would help to check which architectures of the reported failing versions work and which do not. As an example, Daniel reports 12.2-RELEASE as failing, but Wen reports that particular version on i386 as working. So is this specific to amd64? Or is arm affected as well?
(In reply to schaiba from comment #11) > Now, maybe it looks like a non-solution, but do you guys think it would make > sense to postpone the update of this port? Yes, this would make sense, this is a minor update anyway. FYI, the same problem affects GNU grep 3.7 which I've reported upstream: https://lists.gnu.org/archive/html/bug-grep/2021-10/msg00000.html
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c87cdf264642a329edcab4c5ce3b7522ad0601ac commit c87cdf264642a329edcab4c5ce3b7522ad0601ac Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2021-10-15 08:35:26 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2021-10-15 08:35:28 +0000 textproc/diffutils: update the port to version 3.8 and enable tests PR: 257631 textproc/diffutils/Makefile | 3 ++- textproc/diffutils/distinfo | 6 +++--- textproc/diffutils/files/patch-configure (new) | 20 ++++++++++++++++++++ 3 files changed, 25 insertions(+), 4 deletions(-)
Committed now that the problem had been analysed and fixed upstream. Tests are enabled, DISTVERSION abomination waived, LICENSE_FILE is not needed as it's just a standard boilerplate and does not contain actual copyright information.