Bug 257631 - textproc/diffutils: Update to 3.8
Summary: textproc/diffutils: Update to 3.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-08-05 05:58 UTC by schaiba
Modified: 2021-10-15 08:39 UTC (History)
5 users (show)

See Also:
schaiba: maintainer-feedback+


Attachments
diff (875 bytes, patch)
2021-08-05 05:58 UTC, schaiba
no flags Details | Diff
Improved diff according to suggestions (1005 bytes, patch)
2021-08-05 10:01 UTC, schaiba
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description schaiba 2021-08-05 05:58:39 UTC
Created attachment 226964 [details]
diff
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-08-05 07:55:20 UTC
Hi,

Can you add LICENSE_FILE entry, have a look if we can enable unit tests ("make check" in upstream and "make test" for the port) and optionally (recommened by Porters Handbook) update PORTVERSION to DISTVERSION?

Best regards,
Daniel
Comment 2 schaiba 2021-08-05 10:01:53 UTC
Created attachment 226967 [details]
Improved diff according to suggestions
Comment 3 schaiba 2021-08-05 10:02:55 UTC
(In reply to Daniel Engberg from comment #1)
Thanks for the insights. Added a new patch with the suggested additions, except the testing part, which will take more time.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-08-15 22:58:48 UTC
Thanks for your patch, looks good so far!
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2021-09-06 06:09:41 UTC
Hi,

Any progress on the remaining part?

Best regards,
Daniel
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2021-09-11 08:14:23 UTC
Hi,

Fails on 11.4-RELEASE, 12.2-RELEASE and 13-STABLE (log from 13-RELEASE)

--- stackvma.o ---
In file included from stackvma.c:38:
./stackvma.h:31:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION < 0
                    ^
./stackvma.h:38:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION > 0
                    ^
--- sigsegv.o ---
In file included from sigsegv.c:746:
./stackvma.h:31:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION < 0
                    ^
./stackvma.h:38:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION > 0
                    ^
sigsegv.c:972:26: error: invalid token at start of a preprocessor expression
#     if STACK_DIRECTION < 0
                         ^
sigsegv.c:979:29: error: no member named 'is_near_this' in 'struct vma_struct'
                      : vma.is_near_this (addr, &vma))
                        ~~~ ^
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2021-09-11 08:15:02 UTC
err, 13-RELEASE --> 13-STABLE
Comment 8 schaiba 2021-09-12 15:01:07 UTC
(In reply to Daniel Engberg from comment #6)
Thanks for the assistance. Obviously it stems from libsigsegv, I'll have to set up some VM with the reported affected versions and see what I can do.
Comment 9 Wen Heping freebsd_committer freebsd_triage 2021-10-05 08:29:38 UTC
I can build it on 12.2-i386 system.

wen
Comment 10 Daniel Engberg freebsd_committer freebsd_triage 2021-10-05 21:11:22 UTC
Still broken on amd64 unfortunately
Comment 11 schaiba 2021-10-11 05:16:39 UTC
Haven't had time to look at this. Now, maybe it looks like a non-solution, but do you guys think it would make sense to postpone the update of this port? Until when, I don't know. Also, it would help to check which architectures of the reported failing versions work and which do not. As an example, Daniel reports 12.2-RELEASE as failing, but Wen reports that particular version on i386 as working. So is this specific to amd64? Or is arm affected as well?
Comment 12 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-10-12 03:25:55 UTC
(In reply to schaiba from comment #11)
> Now, maybe it looks like a non-solution, but do you guys think it would make
> sense to postpone the update of this port?
Yes, this would make sense, this is a minor update anyway.  FYI, the same problem affects GNU grep 3.7 which I've reported upstream:

  https://lists.gnu.org/archive/html/bug-grep/2021-10/msg00000.html
Comment 13 commit-hook freebsd_committer freebsd_triage 2021-10-15 08:36:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c87cdf264642a329edcab4c5ce3b7522ad0601ac

commit c87cdf264642a329edcab4c5ce3b7522ad0601ac
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-10-15 08:35:26 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-10-15 08:35:28 +0000

    textproc/diffutils: update the port to version 3.8 and enable tests

    PR:     257631

 textproc/diffutils/Makefile                    |  3 ++-
 textproc/diffutils/distinfo                    |  6 +++---
 textproc/diffutils/files/patch-configure (new) | 20 ++++++++++++++++++++
 3 files changed, 25 insertions(+), 4 deletions(-)
Comment 14 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-10-15 08:39:08 UTC
Committed now that the problem had been analysed and fixed upstream.  Tests are enabled, DISTVERSION abomination waived, LICENSE_FILE is not needed as it's just a standard boilerplate and does not contain actual copyright information.