Bug 257631 - textproc/diffutils: Update to 3.8
Summary: textproc/diffutils: Update to 3.8
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-08-05 05:58 UTC by schaiba
Modified: 2021-09-12 15:01 UTC (History)
1 user (show)

See Also:


Attachments
diff (875 bytes, patch)
2021-08-05 05:58 UTC, schaiba
no flags Details | Diff
Improved diff according to suggestions (1005 bytes, patch)
2021-08-05 10:01 UTC, schaiba
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description schaiba 2021-08-05 05:58:39 UTC
Created attachment 226964 [details]
diff
Comment 1 Daniel Engberg freebsd_committer 2021-08-05 07:55:20 UTC
Hi,

Can you add LICENSE_FILE entry, have a look if we can enable unit tests ("make check" in upstream and "make test" for the port) and optionally (recommened by Porters Handbook) update PORTVERSION to DISTVERSION?

Best regards,
Daniel
Comment 2 schaiba 2021-08-05 10:01:53 UTC
Created attachment 226967 [details]
Improved diff according to suggestions
Comment 3 schaiba 2021-08-05 10:02:55 UTC
(In reply to Daniel Engberg from comment #1)
Thanks for the insights. Added a new patch with the suggested additions, except the testing part, which will take more time.
Comment 4 Daniel Engberg freebsd_committer 2021-08-15 22:58:48 UTC
Thanks for your patch, looks good so far!
Comment 5 Daniel Engberg freebsd_committer 2021-09-06 06:09:41 UTC
Hi,

Any progress on the remaining part?

Best regards,
Daniel
Comment 6 Daniel Engberg freebsd_committer 2021-09-11 08:14:23 UTC
Hi,

Fails on 11.4-RELEASE, 12.2-RELEASE and 13-STABLE (log from 13-RELEASE)

--- stackvma.o ---
In file included from stackvma.c:38:
./stackvma.h:31:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION < 0
                    ^
./stackvma.h:38:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION > 0
                    ^
--- sigsegv.o ---
In file included from sigsegv.c:746:
./stackvma.h:31:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION < 0
                    ^
./stackvma.h:38:21: error: invalid token at start of a preprocessor expression
#if STACK_DIRECTION > 0
                    ^
sigsegv.c:972:26: error: invalid token at start of a preprocessor expression
#     if STACK_DIRECTION < 0
                         ^
sigsegv.c:979:29: error: no member named 'is_near_this' in 'struct vma_struct'
                      : vma.is_near_this (addr, &vma))
                        ~~~ ^
Comment 7 Daniel Engberg freebsd_committer 2021-09-11 08:15:02 UTC
err, 13-RELEASE --> 13-STABLE
Comment 8 schaiba 2021-09-12 15:01:07 UTC
(In reply to Daniel Engberg from comment #6)
Thanks for the assistance. Obviously it stems from libsigsegv, I'll have to set up some VM with the reported affected versions and see what I can do.