Bug 257667 - deskutils/gnome-todo: fails to build and caused x11/gnome3 package missing
Summary: deskutils/gnome-todo: fails to build and caused x11/gnome3 package missing
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL: https://reviews.freebsd.org/D31542
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-07 03:05 UTC by Guangyuan Yang
Modified: 2021-09-29 21:17 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Guangyuan Yang freebsd_committer 2021-08-07 03:05:26 UTC
Hi,

deskutils/gnome-todo still seems to fail to build for me even after the recent update, and this failure seems to have prevented x11/gnome3 package to be missing for a while.

[ 16% 34/212] cc -Isrc/plugins/libplugins.a.p -Isrc/plugins -I../src/plugins -I../src/animation -I../src/core -Isrc/gui -I../src/gui -I../src/models -Isrc -I../src -Isrc/plugins/all-tasks-panel -Isrc/plugins/dark-theme -Isrc/plugins/eds -Isrc/plugins/inbox-panel -Isrc/plugins/next-week-panel -Isrc/plugins/night-light -Isrc/plugins/peace -Isrc/plugins/task-lists-workspace -Isrc/plugins/today-panel -Isrc/plugins/welcome -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/gtk-4.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/harfbuzz -I/usr/local/include/freetype2 -I/usr/local/include/fribidi -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/libpng16 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/graphene-1.0 -I/usr/local/lib/graphene-1.0/include -I/usr/local/include/gio-unix-2.0 -I/usr/local/include/libepoll-shim -I/usr/local/include/libadwaita-1 -I/usr/local/include/goa-1.0 -I/usr/local/lib/goa-1.0/include -I/usr/local/include/libpeas-1.0 -I/usr/local/include/gobject-introspection-1.0 -I/usr/local/include/evolution-data-server -I/usr/local/include/libsecret-1 -I/usr/local/include/libxml2 -I/usr/local/include/libsoup-2.4 -I/usr/local/include/nss -I/usr/local/include/nspr -fno-color-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -DHAVE_CONFIG_H -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -fPIC -pthread -mfpmath=sse -msse -msse2 -mfpmath=sse -msse -msse2 -D_THREAD_SAFE -MD -MQ src/plugins/libplugins.a.p/all-tasks-panel_all-tasks-panel-plugin.c.o -MF src/plugins/libplugins.a.p/all-tasks-panel_all-tasks-panel-plugin.c.o.d -o src/plugins/libplugins.a.p/all-tasks-panel_all-tasks-panel-plugin.c.o -c ../src/plugins/all-tasks-panel/all-tasks-panel-plugin.c
FAILED: src/plugins/libplugins.a.p/all-tasks-panel_all-tasks-panel-plugin.c.o 
cc -Isrc/plugins/libplugins.a.p -Isrc/plugins -I../src/plugins -I../src/animation -I../src/core -Isrc/gui -I../src/gui -I../src/models -Isrc -I../src -Isrc/plugins/all-tasks-panel -Isrc/plugins/dark-theme -Isrc/plugins/eds -Isrc/plugins/inbox-panel -Isrc/plugins/next-week-panel -Isrc/plugins/night-light -Isrc/plugins/peace -Isrc/plugins/task-lists-workspace -Isrc/plugins/today-panel -Isrc/plugins/welcome -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/gtk-4.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/harfbuzz -I/usr/local/include/freetype2 -I/usr/local/include/fribidi -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/libpng16 -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/graphene-1.0 -I/usr/local/lib/graphene-1.0/include -I/usr/local/include/gio-unix-2.0 -I/usr/local/include/libepoll-shim -I/usr/local/include/libadwaita-1 -I/usr/local/include/goa-1.0 -I/usr/local/lib/goa-1.0/include -I/usr/local/include/libpeas-1.0 -I/usr/local/include/gobject-introspection-1.0 -I/usr/local/include/evolution-data-server -I/usr/local/include/libsecret-1 -I/usr/local/include/libxml2 -I/usr/local/include/libsoup-2.4 -I/usr/local/include/nss -I/usr/local/include/nspr -fno-color-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -DHAVE_CONFIG_H -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -fPIC -pthread -mfpmath=sse -msse -msse2 -mfpmath=sse -msse -msse2 -D_THREAD_SAFE -MD -MQ src/plugins/libplugins.a.p/all-tasks-panel_all-tasks-panel-plugin.c.o -MF src/plugins/libplugins.a.p/all-tasks-panel_all-tasks-panel-plugin.c.o.d -o src/plugins/libplugins.a.p/all-tasks-panel_all-tasks-panel-plugin.c.o -c ../src/plugins/all-tasks-panel/all-tasks-panel-plugin.c
In file included from ../src/plugins/all-tasks-panel/all-tasks-panel-plugin.c:24:
../src/gnome-todo.h:24:10: fatal error: 'gtd-enum-types.h' file not found
#include "gtd-enum-types.h"
         ^~~~~~~~~~~~~~~~~~
1 error generated.
ninja: build stopped: subcommand failed.
*** Error code 1
Comment 1 Neel Chauhan freebsd_committer 2021-08-07 03:12:57 UTC
I'm from gnome@.

The reason why deskutils/gnome-todo failed for so long:

 * It depends on sysutils/glib20 2.68.x

 * An earlier update to sysutils/glib20 2.68.x was reverted, breaking this port and x11/gnome3

 * sysutils/glib20 2.68.x was eventually committed, so this port should build.

From FreshPorts, gnome-todo is starting to be built: https://www.freshports.org/deskutils/gnome-todo
Comment 2 Guangyuan Yang freebsd_committer 2021-08-07 04:11:19 UTC
(In reply to Neel Chauhan from comment #1)

Hi Neel, thanks for the quick response! I am still seeing the same build error from pkg-fallout as on my desktop just now for 13.0 amd64. Is this a different issue, or the sysutils/glib20 one that you referred to?

https://lists.freebsd.org/archives/freebsd-gnome/2021-August/000648.html
Comment 3 Neel Chauhan freebsd_committer 2021-08-07 05:12:50 UTC
I don't get the pkg fallout on gnome-todo on 13.0. Try with an updated Ports tree, but if not I can look at it.
Comment 4 Guangyuan Yang freebsd_committer 2021-08-07 05:18:49 UTC
(In reply to Neel Chauhan from comment #3)

I just tried building deskutils/gnome-todo in my local Poudriere (13.0-RELEASE, amd64) with the up-to-date ports tree, and got the same failure result. Not sure if there's anything I've done wrong though :(
Comment 5 rkoberman 2021-08-07 23:38:11 UTC
The latest package builder run failed again due to a missing header file:
The long is at:
http://beefy16.nyi.freebsd.org/data/130amd64-default/1684f47e9bea/logs/errors/gnome-todo-40.1.log

Note that this system is only reachable by IPv6.
Comment 6 Neel Chauhan freebsd_committer 2021-08-08 00:31:44 UTC
About my tests, it's that "poudriere testport" works but "poudriere bulk" fails.
Comment 7 Tobias C. Berner freebsd_committer 2021-08-08 05:31:49 UTC
As far as I can see the file is generated during the build.

Two possible issues I can think of:

* glib-mkenums segfaults/fails      
* racing (used before generated) -- try with MAKE_JOBS_UNSAFE=y


mfg Tobias
Comment 8 Guangyuan Yang freebsd_committer 2021-08-14 01:16:43 UTC
Still failing.

Should we temporarily disable gnome-todo from gnome3, to make the gnome3 package available again?
Comment 9 Neel Chauhan freebsd_committer 2021-08-14 01:17:49 UTC
Yes, I would agree with removing gnome-todo from the build temporarily.
Comment 10 commit-hook freebsd_committer 2021-08-15 08:10:38 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=347bb55ed09c8cc62540d6a9f8b1df1f5910d676

commit 347bb55ed09c8cc62540d6a9f8b1df1f5910d676
Author:     Guangyuan Yang <ygy@FreeBSD.org>
AuthorDate: 2021-08-15 07:52:07 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-08-15 08:09:57 +0000

    deskutils/gnome-utils: Temporarily disable deskutils/gnome-todo

    The port deskutils/gnome-todo has failed to build for months, which
    makes deskutils/gnome-utils and eventually x11/gnome3 packages missing.
    The build potentially needs a non-trivial fix, so temporarily remove
    deskutils/gnome-todo from build while the issue is being investigated.

    PR:             257667
    Reviewed by:    tcberner (gnome)

 deskutils/gnome-utils/Makefile | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 11 Guangyuan Yang freebsd_committer 2021-08-15 08:16:10 UTC
Alright, I have removed gnome-todo from build now. Keeping this PR open though to track further investigations regarding its build failure.
Comment 12 Guangyuan Yang freebsd_committer 2021-09-29 16:24:55 UTC
Build is still failing after https://cgit.freebsd.org/ports/commit/?id=34061e4547efaaac738dba4b6ca271c7e1154c6b.
Comment 13 Neel Chauhan freebsd_committer 2021-09-29 20:51:15 UTC
I know the reason why this fails, it fails when we are building gnome-todo with a single core.

On GNOME's GitLab, it also happens on openSUSE: https://gitlab.gnome.org/GNOME/gnome-todo/-/issues/398

This is also why testport works but bulk fails.
Comment 14 commit-hook freebsd_committer 2021-09-29 21:17:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a4faaf6cf7835014b5f69a337b544ea4ee7f9655

commit a4faaf6cf7835014b5f69a337b544ea4ee7f9655
Author:     Neel Chauhan <nc@FreeBSD.org>
AuthorDate: 2021-09-29 21:15:25 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2021-09-29 21:16:37 +0000

    deskutils/gnome-todo: Fix build on poudriere bulk

    This fixes a race condition in building the enums.

    PR:     257667

 .../gnome-todo/files/patch-src_meson.build (new)   | 51 ++++++++++++++++++++++
 1 file changed, 51 insertions(+)