Bug 257687 - graphics/inkscape: fix compilation if POPPLER=off
Summary: graphics/inkscape: fix compilation if POPPLER=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-08 17:55 UTC by Philipp Ost
Modified: 2022-05-15 12:31 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Fix compilation of inkscape if POPPLER=off (1.06 KB, patch)
2021-08-08 17:55 UTC, Philipp Ost 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-08-08 17:55:51 UTC 
Created attachment 227019 [details]
Fix compilation of inkscape if POPPLER=off

Compiling inkscape fails if POPPLER=off. The attached patch carries over the fix from upstream: https://gitlab.com/inkscape/inkscape/-/blob/e8d1acbb2ba23bcbf360bcd1ad6adccd1f6b8a31/src/inkscape-version-info.cpp

This was originally reported by  Alexandre C. Guimarães in Bug 256999.
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-12-11 19:40:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0186d83ae398607ce44184aefecc8aed82b3e163

commit 0186d83ae398607ce44184aefecc8aed82b3e163
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-12-11 19:37:38 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-12-11 19:37:38 +0000

    graphics/inkscape: fix build when POPPLER=OFF

    Obtained from:  https://gitlab.com/inkscape/inkscape/-/commit/7d9497b64df1ec3ddfb65efd105dd11212014ce9
    Reported by:    Philipp Ost <bsd@philippost.de>, rigoletto
    PR:             257687

 graphics/inkscape/Makefile | 3 +++
 graphics/inkscape/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2021-12-11 19:40:32 UTC 
Committed, 

Sorry for the long wait :)


mfg Tobias