Bug 257701 - deskutils/ydotool: drop runtime dependency on boost-libs
Summary: deskutils/ydotool: drop runtime dependency on boost-libs
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2021-08-09 07:07 UTC by Jan Beich
Modified: 2021-08-09 11:18 UTC (History)
1 user (show)

See Also:
jbeich: merge-quarterly?


Attachments
v1 (apply via "git am") (1.47 KB, patch)
2021-08-09 07:07 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-08-09 07:07:36 UTC
Created attachment 227038 [details]
v1 (apply via "git am")

Until review D16457 lands and devel/boost-libs is split let's shave 166 MiB of install size from this otherwise small tool. Maybe MFH to /quarterly as well.

$ poudriere testport -j 122amd64 deskutils/ydotool
[...]
===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
=>> Checking for staging violations... done
[...]
===========================================================================
=>> Checking shared library dependencies
 0x0000000000000001 NEEDED               Shared library: [libc++.so.1]
 0x0000000000000001 NEEDED               Shared library: [libc.so.7]
 0x0000000000000001 NEEDED               Shared library: [libcxxrt.so.1]
 0x0000000000000001 NEEDED               Shared library: [libdl.so.1]
 0x0000000000000001 NEEDED               Shared library: [libepoll-shim.so.0]
 0x0000000000000001 NEEDED               Shared library: [libevdevPlus.so.0]
 0x0000000000000001 NEEDED               Shared library: [libgcc_s.so.1]
 0x0000000000000001 NEEDED               Shared library: [libm.so.5]
 0x0000000000000001 NEEDED               Shared library: [libthr.so.3]
 0x0000000000000001 NEEDED               Shared library: [libuInputPlus.so.0]
 0x0000000000000001 NEEDED               Shared library: [libydotool.so.0]
Comment 1 Daniel Engberg freebsd_committer 2021-08-09 08:14:13 UTC
Please use the STATIC option instead of hardcoding it
Comment 2 Jan Beich freebsd_committer 2021-08-09 08:51:30 UTC
(In reply to Daniel Engberg from comment #1)
STATIC is for creating static executable but the patch here only links Boost statically while the rest (as illustrated in comment 0) is still dynamic. Besides, this is a leaf port that only uses non-networking routines from Boost thus doesn't benefit much from sharing.
Comment 3 Jan Beich freebsd_committer 2021-08-09 08:57:26 UTC
Also, linking Boost statically has to be the default in order to benefit the binary package or there's no point.
Comment 4 Jan Beich freebsd_committer 2021-08-09 11:06:55 UTC
Oops, I didn't notice this port is unmaintained since ports 4f4b3c57bc60.
Comment 5 Jan Beich freebsd_committer 2021-08-09 11:18:12 UTC
ydotool 0.2.0 dropped Boost dependency, see https://github.com/ReimuNotMoe/ydotool/commit/751371b105a8

Abandoning because because my patch is incomplete/unusable:

$ ydotool
ld-elf.so.1: /usr/local/lib/libydotool.so.0: Undefined symbol "_ZN5boost15program_options19options_description21m_default_line_lengthE"