Created attachment 227051 [details] betterlockscreen 3.2.0 Lockscreen with a prettier style
Created attachment 227052 [details] pkg-message added
Hi Fadel, Thanks for the new port. Did you recognize v4.0.0, released a few hours ago?
(In reply to Rainer Hurling from comment #2) I did not realize it, since it came out a few hours after I uploaded it here, after a while I upload version 4.0.0
Created attachment 227088 [details] betterlockscreen 4.0.0
Created attachment 227139 [details] betterlockscreen 4.0.1
Hi Fadel, I tried your patch. It compiles and installs fine, but did not work for me. All I get on the console is the message "[B] Betterlockscreen", no locking. Did you test if it works for you? BTW, the license it not BSD3CLAUSE, but MIT [1] [1] https://github.com/betterlockscreen/betterlockscreen/blob/master/LICENSE
(In reply to Rainer Hurling from comment #6) How strange, it works fine for me, I'm going to try a VM to see if everything is fine
I tested it on a virtual machine with freebsd 13.0 and it works fine. now I attach a patch changing the license to "MIT"
Created attachment 227186 [details] license changed
It looks like it doesn't like our grep and sed. % betterlockscreen -u ./img_0167.jpg [B] Betterlockscreen [*] Updating image cache... [=] Detected 2 display(s) @ 1920x1848 total resolution [=] Original image(s): img_0167.jpg img_0167.jpg usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) [=] Processing display: LVDS-1 (1) [=] Resolution: 1366x768 [*] Resizing base image... [*] Rendering 'dim' effect... [*] Rendering 'blur' effect... [*] Rendering 'dimblur' effect... [*] Rendering 'pixel' effect... [*] Rendering 'dimpixel' effect... [*] Rendering 'color' effect... usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) [=] Processing display: HDMI-1 (2) [=] Resolution: 1920x1080 [*] Resizing base image... [*] Rendering 'dim' effect... [*] Rendering 'blur' effect... [*] Rendering 'dimblur' effect... [*] Rendering 'pixel' effect... [*] Rendering 'dimpixel' effect... [*] Rendering 'color' effect... [*] Creating canvas: 1920x1848 [*] Rendering final wallpaper images... [*] Rendering final lockscreen images... usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\) usage: grep [-abcDEFGHhIiLlmnOoPqRSsUVvwxz] [-A num] [-B num] [-C[num]] [-e pattern] [-f file] [--binary-files=value] [--color=when] [--context[=num]] [--directories=action] [--label] [--line-buffered] [--null] [pattern] [file ...] sed: 1: "s/\s*resolution:\s*([0- ...": RE error: trailing backslash (\)
(In reply to Joseph Mingrone from comment #10) I do not understand why that happens, I tried it on my PC, on a VM and on another PC and it does not give conflicts
Created attachment 227201 [details] GnuGrep added
Created attachment 227210 [details] patch with gnused and gnugrep Hi Fadel, If you want to use the GNU grep version, it is necessary to set the dependency in RUN_DEPENDS to the correct binary as well. Without ${LOCALBASE}/bin the base version is searched for. It is also usually not a good idea to hardcode the path to a binary in a patch. This will no longer work if ${LOCALBASE} is set to a path other than /usr/local, i.e. the user wants to install his packages under a different path. Therefore it is better to set this path via a REINPLACE_CMD in the Makefile. I have attached a patch as a suggestion, which already contains both. This would make your 'files/patch-betterlockscreen' obsolete. ----- Unfortunately 'betterlockscreen' doesn't work as expected for me either despite using the GNU versions. I am using a current 14.0-CURRENT and have no idea what the problem could be. Of course it could also be a local problem on my side ;)
(In reply to Rainer Hurling from comment #13) try testing on a virtual machine
Have you tried replacing Perl extensions instead? \s is same as [[:space:]], see perlre(1) and isspace(3) manpages. post-patch: @${REINPLACE_CMD} -E -e '/grep|sed/s,\\s,[[:space:]],g' \ ${WRKSRC}/${PORTNAME}
(In reply to Jan Beich from comment #15) Nevermind, it also has \d aka [[:digit:]] or isdigit(3) but \K isn't directly translatable. Probably easier to rewrite without preserving regexp quirks e.g., - dpi=$(xrdb -q | grep -oP '^\s*Xft.dpi:\s*\K\d+' | bc) + dpi=$(xrdb -q | awk -F: '/Xft.dpi/ { gsub("[[:space:]]*",""); print $2 }')