Bug 257724 - net-p2p/c-lightning: Needs full path to bitcoind
Summary: net-p2p/c-lightning: Needs full path to bitcoind
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Vasil Dimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-10 03:02 UTC by Peter
Modified: 2021-11-22 12:05 UTC (History)
0 users

See Also:
vd: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter 2021-08-10 03:02:34 UTC
The rc.d file runs bitcoin-cli in function check_bitcoind_ready() but it needs the full path. This is on a freshly built 13.0 system, with stock bitcoin installed.

Also, a feature request: use "daemon" to autorestart lightningd if/when it dies. The rc.d for bitcoind is already doing this, and lightningd is much less mature.

Thanks!
Comment 1 Vasil Dimov freebsd_committer freebsd_triage 2021-08-10 08:44:27 UTC
Makes sense
Comment 2 Vasil Dimov freebsd_committer freebsd_triage 2021-11-22 12:05:22 UTC
In 1ec29872bf758e541e7932b6c449d1a88b59b594 net-p2p/c-lightning was upgraded to 0.10.2.

I added the full path to bitcoin-cli (thus marking this PR as "fixed").

However I did not change it to use daemon(8) to restart lightningd if it dies. I think any unexpected crashes should be thoroughly investigated and reported to the developers. Silently restarting after a crash is like "yeah, it is ok if this crashes 2 times per day, we just restart it". One should be extra careful with this software crashing because it could mean that it has a security issue; it is communicating with remote untrusted peers and is handling money.

net-p2p/bitcoin's rc script uses daemon(8) but it does not use the auto-restart feature (-r).