Bug 257803 - ftp/vsftpd: fix user management with pkg -r
Summary: ftp/vsftpd: fix user management with pkg -r
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-08-13 01:22 UTC by Brad Davis
Modified: 2023-02-13 13:16 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+


Attachments
patch (1.11 KB, patch)
2021-08-13 01:22 UTC, Brad Davis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Davis freebsd_committer freebsd_triage 2021-08-13 01:22:21 UTC
Created attachment 227153 [details]
patch

Not sure why this is being done manually, but it breaks user creation when populating an image with pkg -r and leaves the user/group behind when the pkg is removed.
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2021-08-14 09:59:08 UTC
This is the intended behavior.
on upgraded systems there is an ftp user in the base.
and using USER/GROUP has regressions in this case.

I will test if the regressions still occurs.
Comment 2 Brad Davis freebsd_committer freebsd_triage 2021-08-18 15:20:06 UTC
On upgraded systems? I don't see a ftp user in CURRENT: https://cgit.freebsd.org/src/tree/etc/master.passwd
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2021-08-19 07:43:05 UTC
(In reply to Brad Davis from comment #2)

You have an ftp user on systems which have been upgraded from previous version of ftp. This conflicts with the logic in bsd.port.mk and pkg.
Comment 4 commit-hook freebsd_committer freebsd_triage 2023-02-13 12:39:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=82cb642207a679e6bbbd8fe3caea178f00818ffe

commit 82cb642207a679e6bbbd8fe3caea178f00818ffe
Author:     Dirk Meyer <dinoex@FreeBSD.org>
AuthorDate: 2023-02-13 12:37:48 +0000
Commit:     Dirk Meyer <dinoex@FreeBSD.org>
CommitDate: 2023-02-13 12:37:48 +0000

    ftp/vsftpd: add full dual stack support

    make option PIDFILE default
    add second binary and config for full dual stack support
    use @sample
    fix build for FreeBSD-14

    support: USERS and GROUPS
    PR: 257803

 ftp/vsftpd/Makefile                 | 29 ++++++++++++----------
 ftp/vsftpd/files/chroot.conf (new)  |  7 ++++++
 ftp/vsftpd/files/listen.conf (new)  |  5 ++++
 ftp/vsftpd/files/listen6.conf (new) |  5 ++++
 ftp/vsftpd/files/patch-ssl.c        | 22 +++++++++++++++++
 ftp/vsftpd/files/pidfile.conf (new) |  6 +++++
 ftp/vsftpd/files/vsftpd6.in (new)   | 48 +++++++++++++++++++++++++++++++++++++
 ftp/vsftpd/pkg-plist                |  8 +++----
 8 files changed, 113 insertions(+), 17 deletions(-)