Bug 257882 - german/hunspell: de_CH dictionary wrongly contains 'ß'
Summary: german/hunspell: de_CH dictionary wrongly contains 'ß'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-16 12:02 UTC by Tobias C. Berner
Modified: 2021-08-17 05:28 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments
v1 (1.05 KB, patch)
2021-08-16 12:53 UTC, Tobias C. Berner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer 2021-08-16 12:02:59 UTC
Moin moin 

In swiss-german there is no letter 'ß'. However, the dictionary file installed by german/hunspell [1] is full of them (which kind of makes it useleß :) ).


mfg Tobias

[1] /usr/local/share/hunspell/de_CH.dic
Comment 1 Herbert J. Skuhra 2021-08-16 12:39:20 UTC
There is obviously a problem with work/igerman98-20161207/bin/conv_dict_de_CH. 

/bin/sh: ./bin/conv_dict_de_CH: not found

It tries to execute /bin/sed instead of /usr/bin/sed.
Comment 2 Tobias C. Berner freebsd_committer 2021-08-16 12:53:11 UTC
Created attachment 227243 [details]
v1

Oh, great catch, thank you.

The patch [1] should fix this.

mfg Tobias

[1] https://people.freebsd.org/~tcberner/patches/0001-german-hunspell-fix-swiss-german-dictionnary.patch
Comment 3 Herbert J. Skuhra 2021-08-16 13:03:34 UTC
Yes, it seems to work!
Comment 4 commit-hook freebsd_committer 2021-08-17 05:26:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b26637cd90d6e9b3f8a392e293cd5e181f51c64

commit 3b26637cd90d6e9b3f8a392e293cd5e181f51c64
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-08-16 12:50:42 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-08-17 05:24:08 +0000

    german/hunspell: fix swiss-german dictionary

    - The swiss-german dictionary was not properly prepared, as the used
      sed (/bin/sed) was unable to replace 'ß' by 'ss'.

    - Use the shebangfix framework to make it use gsed, which is already
      depended on.

    Approved by:    office (fluffy)
    PR:             257882

 german/hunspell/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 5 commit-hook freebsd_committer 2021-08-17 05:27:28 UTC
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=32cf8dd59c513ac04f8d91e77b1f04c8768b70fb

commit 32cf8dd59c513ac04f8d91e77b1f04c8768b70fb
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-08-16 12:50:42 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-08-17 05:27:04 +0000

    german/hunspell: fix swiss-german dictionary

    - The swiss-german dictionary was not properly prepared, as the used
      sed (/bin/sed) was unable to replace 'ß' by 'ss'.

    - Use the shebangfix framework to make it use gsed, which is already
      depended on.

    Approved by:    office (fluffy)
    PR:             257882

    (cherry picked from commit 3b26637cd90d6e9b3f8a392e293cd5e181f51c64)

 german/hunspell/Makefile | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Comment 6 Tobias C. Berner freebsd_committer 2021-08-17 05:28:07 UTC
Committed.