Bug 257891 - math/linbox: add OpenCL dependency
Summary: math/linbox: add OpenCL dependency
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-16 20:59 UTC by Philipp Ost
Modified: 2021-08-24 15:53 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (thierry)


Attachments
math/linbox: add ocl dependency (1.10 KB, patch)
2021-08-16 20:59 UTC, Philipp Ost
no flags Details | Diff
math/linbox: add ocl dependency (1.66 KB, patch)
2021-08-24 15:53 UTC, Philipp Ost
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Ost 2021-08-16 20:59:10 UTC
Created attachment 227252 [details]
math/linbox: add ocl dependency

math/linbox currently picks up libOpenCL.so if it is present on the system, but does not declare it as a dependency. The attached patch adds it as a library dependency to the complete package and disables it for the minimal package.

This came up in testing my changes: iff MIN=on, then LinBox unconditionally picks up libflint.so and libtinyxml2.so if they are present on the system. Adding --without-flint to the configure arguments does not have an effect. There seems to be no option to disable tinyxml2 (the doxygen option is off).
Comment 1 Thierry Thomas freebsd_committer 2021-08-24 13:38:31 UTC
You are right, it depends on libOpenCL.so when devel/ocl-icd is installed!

But have'nt you noticed anything about pkg-plist?

On my workstation (13-STABLE), installed from the ports, I must insert the following line:
%%FULL%%include/linbox/algorithms/opencl-kernels/opencl-domain-kernels.inl

but in poudriere, this file is not installed, and I have not yet found the reason.
Comment 2 Philipp Ost 2021-08-24 15:53:25 UTC
Created attachment 227404 [details]
math/linbox: add ocl dependency

I missed checking for changes to pkg-plist. Sorry about that. I revised my patch to include the missing file.

opencl-domain-kernels.inl is generated by ${WRKSRC}/linbox/algorithms/opencl-kernels/kernel-parser.py and referenced in the Makefile in same directory. Skimming through that Makefile, I see no reason for that include file to not be installed.

poudriere testport is currently running, I'll report back if I find something.