Created attachment 227277 [details] "git diff" to update the port - update 2.071 -> 2.072 Changes: https://metacpan.org/dist/IO-Socket-SSL/changes - "portlint -AC" says: looks fine. - "portclippy Makefile" is happy. - Tested with: 13.0-RELEASE-p3 pkg 1.17.1 poudriere 3.3.6 perl 5.32.1 openssl 1.1.1k ssl=base - built-in perl tests in a clean poudriere jail say: PASS.
Created attachment 227281 [details] "git diff" to update the port reformated Hello, I'm thinking that this port could have some small fixes and formating: 1. Use DISTVERSION instead of PORTVERSION: --- Example 2. Using DISTVERSION When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION. https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-naming --- 2. Alphatical order in RUN_DEPENDS: --- -RUN_DEPENDS= p5-Net-SSLeay>=1.59:security/p5-Net-SSLeay \ - p5-Mozilla-CA>=20130114:www/p5-Mozilla-CA +RUN_DEPENDS= p5-Mozilla-CA>=20130114:www/p5-Mozilla-CA \ + p5-Net-SSLeay>=1.59:security/p5-Net-SSLeay --- with p5-'M'ozilla-CA first and p5-'N'et-SSLeay next 3. Add and extra tab in +OPTIONS_DEFINE so it can be aligned with variables bellow: --- -OPTIONS_DEFINE= EXAMPLES IDN IPV6 +OPTIONS_DEFINE= EXAMPLES IDN IPV6 --- I've used portfmt tool to check Makefile formating but sometimes it could lead to mistakes. With this port I think it worked fine. Please check my patch and tell me if it is ok. Thanks 3. Add an extra tab
(In reply to Nuno Teixeira from comment #1) Your patch it is ok. Thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2300a1c073e067ba2a7684cdd877945c0f0d1471 commit 2300a1c073e067ba2a7684cdd877945c0f0d1471 Author: Sergei Vyshenski <svysh.fbsd@gmail.com> AuthorDate: 2021-08-17 14:47:12 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2021-08-17 14:51:06 +0000 security/p5-IO-Socket-SSL: Update to 2.072 * Use DISTVERSION instead of PORTVERSION * reformat Makefile with portfmt ChangeLog: https://metacpan.org/dist/IO-Socket-SSL/changes PR: 257910 security/p5-IO-Socket-SSL/Makefile | 8 ++++---- security/p5-IO-Socket-SSL/distinfo | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-)
Committed thanks!