Bug 257917 - x11-toolkits/libadwaita: update to 0.0.20210812
Summary: x11-toolkits/libadwaita: update to 0.0.20210812
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL: https://gitlab.gnome.org/GNOME/libadw...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-08-17 19:30 UTC by Jan Beich
Modified: 2021-08-24 14:31 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
v1 (apply via "git am") (25.74 KB, patch)
2021-08-17 19:30 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-08-17 19:30:34 UTC
Created attachment 227289 [details]
v1 (apply via "git am")

- Required to drop multimedia/kooha/files/patch-libadwaita
- See URL bugzilla field for upstream changelog
Comment 1 Greg V 2021-08-20 11:20:12 UTC
hm, there are tagged alpha releases now:

https://gitlab.gnome.org/GNOME/libadwaita/-/tree/1.0.0-alpha.2
Comment 2 Jan Beich freebsd_committer 2021-08-20 19:33:47 UTC
(In reply to Greg V from comment #1)
Converting to USE_GITLAB still requires commit hash (see bug 242329). Besides, 1.0.0-alpha.2 isn't enough for Kooha:

$ git describe --contains ea7ef0f2e2ac 2>/dev/null || git describe ea7ef0f2e2ac
1.0.0-alpha.2~37 # 37 commits *before* release

$ git describe --contains 9b6efa65dabb 2>/dev/null || git describe 9b6efa65dabb
1.0.0-alpha.2-49-g9b6efa6 # 49 commits *after* release

# Test build with 1.0.0-alpha.2
$ make clean all -C multimedia/kooha
[...]
  = note: ld: error: undefined symbol: adw_application_get_type
          >>> referenced by libadwaita.7p6l4f4a-cgu.12
          >>>               libadwaita-7c6b5bbcb5cc3eca.libadwaita.7p6l4f4a-cgu.12.rcgu.o:(_$LT$libadwaita..auto..application..Application$u20$as$u20$glib..types..StaticType$GT$::static_type::h53db6c96972ec330) in archive .../Kooha-1.2.1-624-gba1f8e8/_build/target/release/deps/liblibadwaita-7c6b5bbcb5cc3eca.rlib
Comment 3 commit-hook freebsd_committer 2021-08-24 14:26:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a26a1bf68d602ec87c0988bca26ccccad99a7dbd

commit a26a1bf68d602ec87c0988bca26ccccad99a7dbd
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-08-17 19:14:59 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-08-24 14:24:05 +0000

    x11-toolkits/libadwaita: update to 0.0.20210812

    - Drop no longer necessary libadwaita workaround in kooha

    Changes:        https://gitlab.gnome.org/GNOME/libadwaita/-/compare/7f61711...8442d60
    PR:             257917

 multimedia/kooha/Makefile                      |   1 +
 multimedia/kooha/files/patch-libadwaita (gone) | 173 -------------------------
 x11-toolkits/libadwaita/Makefile               |   5 +-
 x11-toolkits/libadwaita/distinfo               |   6 +-
 x11-toolkits/libadwaita/pkg-plist              |  85 +++++++++++-
 5 files changed, 88 insertions(+), 182 deletions(-)
Comment 4 commit-hook freebsd_committer 2021-08-24 14:26:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=525b6bd0b1114aa3ce13337bbb9106f876c1537d

commit 525b6bd0b1114aa3ce13337bbb9106f876c1537d
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-08-24 13:22:53 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-08-24 14:24:04 +0000

    x11-toolkits/libadwaita: expose translations

    PR:             257917

 x11-toolkits/libadwaita/Makefile  |  4 ++--
 x11-toolkits/libadwaita/pkg-plist | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 2 deletions(-)
Comment 5 Jan Beich freebsd_committer 2021-08-24 14:31:38 UTC
I decided to not torture gnome@ testing my ports. ;)

$ pkg rquery %rn libadwaita | xargs pkg rquery '%o is maintained by %m' | sort
audio/shortwave is maintained by jbeich@FreeBSD.org
deskutils/gnome-todo is maintained by gnome@FreeBSD.org
deskutils/solanum is maintained by jbeich@FreeBSD.org
multimedia/kooha is maintained by jbeich@FreeBSD.org
security/authenticator is maintained by jbeich@FreeBSD.org