Bug 257959 - devel/git: Add support for custom ident expansion (i.e. $FreeBSD$).
Summary: devel/git: Add support for custom ident expansion (i.e. $FreeBSD$).
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Renato Botelho
URL:
Keywords: feature
Depends on:
Blocks:
 
Reported: 2021-08-20 03:52 UTC by Maxim Sobolev
Modified: 2022-08-12 13:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (garga)


Attachments
Patch implementing the feature. (9.96 KB, patch)
2021-08-20 03:52 UTC, Maxim Sobolev
no flags Details | Diff
Patch implementing the feature. (14.80 KB, patch)
2021-08-20 19:15 UTC, Maxim Sobolev
no flags Details | Diff
Patch implementing the feature. (15.17 KB, patch)
2021-08-21 22:25 UTC, Maxim Sobolev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Sobolev freebsd_committer freebsd_triage 2021-08-20 03:52:29 UTC
Created attachment 227336 [details]
Patch implementing the feature.

Since migration of FreeBSD repos to git many people complained about missing support for expansion of the $FreeBSD$ tags. This patch builds upon existing ident functionality in Git allowing custom ident to be configured, i.e.:


$ echo '* ident=FreeBSD' >> .gitattributes
$ git add .gitattributes
$ git commit .gitattributes

Next time sources are checked tags are going to be expanded.

Patch will be upstreamed as a pull request to the git project.
Comment 1 Maxim Sobolev freebsd_committer freebsd_triage 2021-08-20 19:15:46 UTC
Created attachment 227348 [details]
Patch implementing the feature.

Updated patch to apply to the latest 2.32.0 version of the port. Thanks!
Comment 2 Maxim Sobolev freebsd_committer freebsd_triage 2021-08-21 22:25:02 UTC
Created attachment 227360 [details]
Patch implementing the feature.

Patch has been updated to match pull request here https://github.com/git/git/pull/1074

Thanks!
Comment 3 Renato Botelho freebsd_committer freebsd_triage 2022-04-12 20:55:46 UTC
(In reply to Maxim Sobolev from comment #2)
I prefer to wait this change to be accepted upstream than carry an extra patch for it.  Are you still working with git developers to get it integrated?
Comment 4 Renato Botelho freebsd_committer freebsd_triage 2022-08-12 13:47:58 UTC
Upstream PR has no activity since last year and I wouldn't like to add such big change only on ports.  If PR is accepted we can reopen it