Bug 258009 - [new port] sysutils/fusefs-xfuse: Read-only FUSE server implementing XFS
Summary: [new port] sysutils/fusefs-xfuse: Read-only FUSE server implementing XFS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pedro F. Giffuni
URL: https://wiki.freebsd.org/SummerOfCode...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-23 16:41 UTC by Khaled Emara
Modified: 2021-08-24 14:08 UTC (History)
2 users (show)

See Also:


Attachments
Patch File to create the Port (7.34 KB, patch)
2021-08-23 16:41 UTC, Khaled Emara
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Khaled Emara 2021-08-23 16:41:59 UTC
Created attachment 227382 [details]
Patch File to create the Port

XFS filesystem implementation in userland.
Comment 1 Pedro F. Giffuni freebsd_committer 2021-08-24 04:51:40 UTC
I had to upadte a checksum.

Do note there are some warnings:

  --> /usr/ports/sysutils/fusefs-xfuse/work/xfuse-0.1.0-alpha/cargo-crates/fuse-0.3.1/src/channel.rs:37:23
   |
37 |             let mnt = try!(CString::new(mountpoint.as_os_str().as_bytes()));
   |                       ^^^

warning: use of deprecated macro `try`: use the `?` operator instead

...

warning: use of deprecated associated function `std::error::Error::description`: use the Display impl or to_string()
   --> /usr/ports/sysutils/fusefs-xfuse/work/xfuse-0.1.0-alpha/cargo-crates/clap-2.33.3/src/errors.rs:910:35

  --> /usr/ports/sysutils/fusefs-xfuse/work/xfuse-0.1.0-alpha/cargo-crates/clap-2.33.3/src/usage_parser.rs:64:13
   |
64 | /             format!(
65 | |                 "No name found for Arg when parsing usage string: {}",
66 | |                 self.usage
67 | |             )
   | |_____________^
   |
   = note: this is no longer accepted in Rust 2021
   = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
help: remove the `format!(..)` macro call
Comment 2 Alan Somers freebsd_committer 2021-08-24 13:34:15 UTC
Those warnings aren't coming from Khaled's code, they're coming from other crates.  There isn't much that he can do about that.
Comment 3 Pedro F. Giffuni freebsd_committer 2021-08-24 14:01:24 UTC
(In reply to Alan Somers from comment #2)

The fear is that clap will be having issues in 2021 and we are in 2021 :).

But you are right, it is important to have more testers, and there aren't many other options so it's committed.

Thanks Khaled!
Comment 4 Alan Somers freebsd_committer 2021-08-24 14:04:50 UTC
(In reply to Pedro F. Giffuni from comment #3)
It's not as bad as you're thinking Pedro.  That warning refers to Rust edition 2021, just like there are C99 and C11 editions.  The warning means that you won't be able to build Clap in Rust 2021 mode until you fix the code.  However, the warning is even less serious than a similar warning in C would be, because a Rust crate can still be built for one edition and consumed by a crate built using a later edition.

The warning should be fixed, but we don't need to worry about it.  We can rely on Clap's developers to do it.  Clap is a very popular crate; this won't go unnoticed.
Comment 5 Pedro F. Giffuni freebsd_committer 2021-08-24 14:08:41 UTC
(In reply to Alan Somers from comment #4)

OK excellent!