Bug 258033 - devel/py-b2sdk: Update to 1.12.0
Summary: devel/py-b2sdk: Update to 1.12.0
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/Backblaze/b2-sdk-p...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-08-24 22:42 UTC by Henry
Modified: 2021-08-25 01:51 UTC (History)
3 users (show)

See Also:
PopularMoment: maintainer-feedback+


Attachments
diff (1.19 KB, patch)
2021-08-24 22:42 UTC, Henry
no flags Details | Diff
patch (2.28 KB, patch)
2021-08-25 01:19 UTC, Henry
no flags Details | Diff
patch (2.33 KB, patch)
2021-08-25 01:46 UTC, Henry
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henry 2021-08-24 22:42:23 UTC
Created attachment 227417 [details]
diff
Comment 1 Nuno Teixeira freebsd_committer 2021-08-24 23:16:42 UTC
Hello!

I found that some small style fixes could be applied to Makefile:

1 'portlint -C' (included in point 2)
---
WARN: Makefile: [32]: use a tab (not space) after a variable name
---

2. 'portfmt -D Makefile' (_DEPENDS and USE_ alphabetical order)
---
--- Makefile
+++ Makefile
@@ -16,13 +16,13 @@
                ${PYTHON_PKGNAMEPREFIX}requests>=2.9.1:www/py-requests@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}setuptools>0:devel/py-setuptools@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}setuptools_scm>0:devel/py-setuptools_scm@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}tqdm>=4.5.0:misc/py-tqdm@${PY_FLAVOR}
+TEST_DEPENDS=  ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}nose>0:devel/py-nose@${PY_FLAVOR}
-               ${PYTHON_PKGNAMEPREFIX}tqdm>=4.5.0:misc/py-tqdm@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${PY_FLAVOR}
-TEST_DEPENDS=  ${PYTHON_PKGNAMEPREFIX}nose>0:devel/py-nose@${PY_FLAVOR} \
-               ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock@${PY_FLAVOR}

 USES=          python:3.6+
+USE_PYTHON=    autoplist concurrent distutils
-USE_PYTHON=    distutils autoplist concurrent

 NO_ARCH=       yes

@@ -29,7 +29,7 @@
 .include <bsd.port.pre.mk>

 .if ${PYTHON_REL} < 30800
+RUN_DEPENDS+=  ${PYTHON_PKGNAMEPREFIX}importlib-metadata>=0:devel/py-importlib-metadata@${PY_FLAVOR}
-RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}importlib-metadata>=0:devel/py-importlib-metadata@${PY_FLAVOR}

Thanks
---
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-25 00:52:41 UTC
Review items:

+	@${REINPLACE_CMD} -e '1 s|,.*||' ${WRKSRC}/requirements.txt
+	@${REINPLACE_CMD} -i '' -e '1 s|<.*||' ${WRKSRC}/*/requires.txt

Can you detail the rationale for these changes?

^Triage:

  - [tags] in issue Titles are deprecated
  - If there is a changelog or release notes URL available for this version, please add it to the URL field
  - Set attachment maintainer-approval flag (to +) on patches for ports you maintain to signify approval:

Attachment -> Details -> maintainer-approval [?]
Comment 3 Henry 2021-08-25 01:19:10 UTC
Created attachment 227418 [details]
patch

Updated patch with dependencies sorted and minor white space changes.
Comment 4 Henry 2021-08-25 01:21:26 UTC
(In reply to Kubilay Kocak from comment #2)
This is required due to the overly restrictive arrow dependency definition.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-25 01:35:07 UTC
(In reply to Henry from comment #4)

Thanks Henry. When doing that (which is fine), either:

- Add comments above the patch block clarifying what/why, like:

 # Remove pinned upper bound version-specs

or

- Do this with an explicit files/patch-* files so the specific dependencies and changes can be seen.

It's also highly recommended to ask upstream to use appropriate version-specs for distributed/distribution packages

Lastly, when patching dependency version specs, confirming that the package still functions appropriately, via upstreams test suite, is absolutely necessary [1] Can you confirm the port passes tests with current versions of ports in the tree? 

Thanks!

[1] https://wiki.freebsd.org/Python/PortsPolicy#Modifying_Dependencies
Comment 6 Henry 2021-08-25 01:46:58 UTC
Created attachment 227419 [details]
patch

Add comment describing reason for requirements/requires patching.
Comment 7 Henry 2021-08-25 01:51:45 UTC
(In reply to Kubilay Kocak from comment #5)
I can confirm the only consumer of this, sysutils/duplicity, functions correctly and passes the test suite.