Bug 258132 - mail/cone: Update to 1.2.1 and take maintainership
Summary: mail/cone: Update to 1.2.1 and take maintainership
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-29 07:59 UTC by Chris Petrik
Modified: 2021-09-14 13:55 UTC (History)
1 user (show)

See Also:


Attachments
patch (1.15 KB, patch)
2021-08-29 07:59 UTC, Chris Petrik
no flags Details | Diff
patch (2.40 KB, patch)
2021-09-13 22:35 UTC, Chris Petrik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Petrik 2021-08-29 07:59:15 UTC
Created attachment 227524 [details]
patch

Update to 1.2.1
Take maintainer

the files in files/* need to be removed I don't know how to do this with svn it was svn diff -N but git is different.

one was to fix a clang issue the other was to add time.h both no longer required.
Comment 1 Guangyuan Yang freebsd_committer 2021-09-13 17:20:37 UTC
(In reply to Chris Petrik from comment #0)

Could you please update your patch to include the removal of files/*? If you have any trouble doing that, please feel free to reach out.
Comment 2 Chris Petrik 2021-09-13 18:45:01 UTC
I do not know how to do this with git
Comment 3 Guangyuan Yang freebsd_committer 2021-09-13 19:38:00 UTC
(In reply to Chris Petrik from comment #2)

You should just remove the files and then do "git add .", and "git diff --staged". The diff will then include the deleted files.
Comment 4 Chris Petrik 2021-09-13 22:12:28 UTC
I am sure you are capable of removing the files yourself with git rm git diff --stage does not give the same output as svn diff -N does. 

The time it has taken you to reply to this you could of removed the files and commited the update.

git add . && git diff --staging doesnt show anything besides the same patch as before.
Comment 5 Chris Petrik 2021-09-13 22:35:16 UTC
Created attachment 227886 [details]
patch

New patch as requested.

instructions were wrong and I had to

git clone , rm x, git commit , git add . , git diff --cached.
Comment 6 Guangyuan Yang freebsd_committer 2021-09-14 12:48:35 UTC
(In reply to Chris Petrik from comment #4)

First of all, sorry for the delay - it is not until I was committing your patch did I notice that you mentioned that the patch is not complete.

I hope that you don't take this the wrong way. Of course I can just remove the files, while replying you take longer. But since you are taking the maintainership, it is reasonable for me to see that you are capable of basic usage of git for maintaining this in the future. I offered to help, however, the responses that I have got is not very constructive and not very kind.

Return this back to pool as I don't have further time to test it.