Bug 258185 - net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script.
Summary: net/dhcpcd: Switch keyword from nojail to nojailvnet in rc script.
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-31 18:08 UTC by Lucas Toole
Modified: 2021-08-31 19:39 UTC (History)
1 user (show)

See Also:
driesm.michiels: maintainer-feedback+


Attachments
Diff for nojail -> nojailvnet (295 bytes, patch)
2021-08-31 18:08 UTC, Lucas Toole
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Toole 2021-08-31 18:08:07 UTC
Created attachment 227573 [details]
Diff for nojail -> nojailvnet

By default dhcpcd has the nojail keyword enabled in the rc script. It was added back in 2007[0] and I assume it is just a remnant of the pre-vnet days. I've been using dhcpcd exclusively in my vnet jails by manually changing the keyword to nojailvnet (Only allow vnet-enabled jails) and have experienced no problems over the past couple weeks.

I'm adding a diff to make this the default keyword, and would love to hear any concerns anyone might have.

[0]https://cgit.freebsd.org/ports/commit/?id=c7e6df59748cd15ebea3c4e83e7f3bcdda529879
Comment 1 Dries Michiels 2021-08-31 18:09:24 UTC
Was planning to take this in with the 9.4.1 update, but doesn't matter my local change looks identically.