Bug 258216 - sysutils/tealdeer: zsh completion installed to wrong directory
Summary: sysutils/tealdeer: zsh completion installed to wrong directory
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lewis Cook
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-02 15:46 UTC by Oliver Kiddle
Modified: 2021-09-09 09:52 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (lcook)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Kiddle 2021-09-02 15:46:54 UTC
The tealdeer port is installed to a directory named site_functions. The correct naming should use a dash instead of an underscore, i.e. site-functions. This appears to be done explicitly from the Makefile with the file copied to ${STAGEDIR}${PREFIX}/share/zsh/site_functions/_tldr. The packaged version of zsh looks in site-functions instead.
Comment 1 commit-hook freebsd_committer 2021-09-09 09:47:32 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0449e53a86ea305b94f66a6c14e76915ba5aeb1f

commit 0449e53a86ea305b94f66a6c14e76915ba5aeb1f
Author:     Lewis Cook <lcook@FreeBSD.org>
AuthorDate: 2021-09-09 09:43:31 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2021-09-09 09:46:13 +0000

    sysutils/tealdeer: Fix zsh shell completion path

    PR:             258216
    Reported by:    Oliver Kiddle <okiddle@yahoo.co.uk>
    MFH:            2021Q3

 sysutils/tealdeer/Makefile | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
Comment 2 commit-hook freebsd_committer 2021-09-09 09:52:33 UTC
A commit in branch 2021Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=59aef785e44be990d8b2f2d71349575dc512991f

commit 59aef785e44be990d8b2f2d71349575dc512991f
Author:     Lewis Cook <lcook@FreeBSD.org>
AuthorDate: 2021-09-09 09:43:31 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2021-09-09 09:50:44 +0000

    sysutils/tealdeer: Fix zsh shell completion path

    PR:             258216
    Reported by:    Oliver Kiddle <okiddle@yahoo.co.uk>
    MFH:            2021Q3

    (cherry picked from commit 0449e53a86ea305b94f66a6c14e76915ba5aeb1f)

 sysutils/tealdeer/Makefile | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
Comment 3 Lewis Cook freebsd_committer freebsd_triage 2021-09-09 09:52:42 UTC
Thanks for reporting! Committed and merged back into 2021Q3.