Bug 258238 - sysutils/zfs-stats update package description and WWW
Summary: sysutils/zfs-stats update package description and WWW
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joel Bodenmann
URL: https://www.freshports.org/sysutils/z...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-03 05:36 UTC by Graham Perrin
Modified: 2023-10-30 12:14 UTC (History)
5 users (show)

See Also:
jbo: maintainer-feedback-
grahamperrin: maintainer-feedback? (mm)


Attachments
[PATCH 1/2] sysutils/zfs-stats: update description and WWW (1.57 KB, patch)
2023-08-05 01:38 UTC, Andrey Korobkov
no flags Details | Diff
[PATCH 2/2] sysutils/zfs-stats: remove unneded shebangfix; was fixed in upstream (1.09 KB, patch)
2023-08-05 01:39 UTC, Andrey Korobkov
no flags Details | Diff
[PATCH 1/2] sysutils/zfs-stats: Update pkg-descr and WWW (1.58 KB, patch)
2023-08-05 10:45 UTC, Andrey Korobkov
alster: maintainer-approval? (mm)
Details | Diff
[PATCH 2/2] sysutils/zfs-stats: Drop shebangfix, fixed in upstream (1.09 KB, patch)
2023-08-05 10:52 UTC, Andrey Korobkov
no flags Details | Diff
[PATCH 2/2] sysutils/zfs-stats: Drop shebangfix, fixed in upstream (1.23 KB, patch)
2023-08-06 15:31 UTC, Andrey Korobkov
alster: maintainer-approval? (mm)
Details | Diff
signed-off patch file (1.07 KB, patch)
2023-10-11 00:21 UTC, Graham Perrin
grahamperrin: maintainer-approval? (mm)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Perrin freebsd_committer freebsd_triage 2021-09-03 05:36:58 UTC
Cross-reference <https://github.com/mmatuska/zfs-stats/pull/8>
Comment 1 Andrey Korobkov 2023-08-05 01:38:23 UTC
Created attachment 243852 [details]
[PATCH 1/2] sysutils/zfs-stats: update description and WWW
Comment 2 Andrey Korobkov 2023-08-05 01:39:18 UTC
Created attachment 243853 [details]
[PATCH 2/2] sysutils/zfs-stats: remove unneded shebangfix; was fixed in upstream
Comment 3 Andrey Korobkov 2023-08-05 10:45:28 UTC
Created attachment 243860 [details]
[PATCH 1/2] sysutils/zfs-stats: Update pkg-descr and WWW
Comment 4 Andrey Korobkov 2023-08-05 10:52:06 UTC
Created attachment 243861 [details]
[PATCH 2/2] sysutils/zfs-stats: Drop shebangfix, fixed in upstream
Comment 5 Andrey Korobkov 2023-08-06 15:31:45 UTC
Created attachment 243898 [details]
[PATCH 2/2] sysutils/zfs-stats: Drop shebangfix, fixed in upstream
Comment 6 Joel Bodenmann freebsd_committer freebsd_triage 2023-09-12 20:42:22 UTC
Maintainer timeout
Comment 7 commit-hook freebsd_committer freebsd_triage 2023-09-12 20:47:06 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8ab46275a6c0f578c697bd9051559083a0d0306f

commit 8ab46275a6c0f578c697bd9051559083a0d0306f
Author:     Andrey Korobkov <alster@vinterdalen.se>
AuthorDate: 2023-09-12 16:03:25 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2023-09-12 20:45:24 +0000

    sysutils/zfs-stats: Remove obsolete shebangfix and update pkg-descr

    While here, also cleanup some other port aspects.

    PR:                     258238
    Approved by:            tcberner (mentor), mm (maintainer, timeout)
    Differential Revision:  https://reviews.freebsd.org/D41835

 sysutils/zfs-stats/Makefile  | 14 ++++++--------
 sysutils/zfs-stats/pkg-descr | 11 +++++++----
 2 files changed, 13 insertions(+), 12 deletions(-)
Comment 8 Joel Bodenmann freebsd_committer freebsd_triage 2023-09-12 20:47:25 UTC
Committed, thanks!
Comment 9 Graham Perrin freebsd_committer freebsd_triage 2023-09-13 03:44:22 UTC
<https://www.freshports.org/sysutils/zfs-stats/>

<https://github.com/grahamperrin/freebsd-ports/pull/3.patch> for a signed-off patch file from the linked pull request (PR). 

----

^Triage, for this bug report

Re: <https://bugs.freebsd.org/bugzilla/show_activity.cgi?id=258238>, mm@ will have lost sight of changes to this BR, so I'm flagging him for feedback with regard to the PR. 

@jbo if you prefer, make mm@ a CC recipient instead. 

----

Generally, for the future, a gentle hint: 

* wherever a review in Phabricator will relate to a bug report in Bugzilla 
  (and/or an issue or MR or PR in GitLab, GitHub or Codeberg), please 
  make followers aware reasonably soon after review begins, certainly 
  before completion of the review. 

Thanks

:-)
Comment 10 Felix Palmen freebsd_committer freebsd_triage 2023-09-13 13:57:52 UTC
(In reply to Graham Perrin from comment #9)
I can't decipher what you would like to see changed here. Please express it in simple and clear words instead of a pile of links of questionable relevance, thanks.
Comment 11 Graham Perrin 2023-10-11 00:21:46 UTC
Created attachment 245558 [details]
signed-off patch file

(In reply to Graham Perrin from comment #9)

> See Also: … https://github.com/grahamperrin/freebsd-ports/pull/3
> Flags: maintainer-feedback?(mm@…)

> <https://www.freshports.org/sysutils/zfs-stats/>
> 
> <https://github.com/grahamperrin/freebsd-ports/pull/3.patch> for a 
> signed-off patch file from the linked pull request (PR). 

mm@ (maintainer, as shown in FreshPorts): the file now attached here in Bugzilla is for approval by you. 

File and commit message taken from the pull request. Discussed with Joel. 

@mm thank you.
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-10-30 12:13:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c5fc53ebce498c84022f85b7357940dc3c9dafde

commit c5fc53ebce498c84022f85b7357940dc3c9dafde
Author:     Graham Perrin <grahamperrin@gmail.com>
AuthorDate: 2023-09-13 03:08:25 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2023-10-30 12:12:46 +0000

    sysutils/zfs-stats: Update WWW

    Since we lost sight of the fact that this port is of a fork, it is no longer
    appropriate to use the original (non-fork) URL for WWW purposes.
    Instead, use the URL of the fork.

    PR:                     258238
    Approved by:            zirias (mentor), mm (maintainer, timeout)
    Differential Revision:  https://reviews.freebsd.org/D42397

 sysutils/zfs-stats/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 13 Joel Bodenmann freebsd_committer freebsd_triage 2023-10-30 12:14:51 UTC
WWW updated - Thanks Graham Perrin.