Bug 258253 - lang/go size mismatch for the latest patch
Summary: lang/go size mismatch for the latest patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-03 16:24 UTC by Alex
Modified: 2021-09-03 20:37 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (dmgk)


Attachments
build log (6.34 KB, text/plain)
2021-09-03 16:24 UTC, Alex
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2021-09-03 16:24:36 UTC
Created attachment 227647 [details]
build log

Hello,


There's a size mismatch after for latest patch regarding the RWX stack patch(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258241) 

fetch: https://github.com/golang/go/commit/782aa42255163559c5e1c4c2d98c8f28da8cf96b.patch: size mismatch: expected 1111, actual 1113 

Thanks very much!
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-09-03 17:15:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=34c43da970f4ddf52a5f452af174a833955a6ffe

commit 34c43da970f4ddf52a5f452af174a833955a6ffe
Author:     Dmitri Goutnik <dmgk@FreeBSD.org>
AuthorDate: 2021-09-03 16:53:45 +0000
Commit:     Dmitri Goutnik <dmgk@FreeBSD.org>
CommitDate: 2021-09-03 17:14:44 +0000

    lang/go: correct patch size mismatch

    Github seems to be undecided whether
    782aa42255163559c5e1c4c2d98c8f28da8cf96b.patch size should be 1111 or
    1113 bytes. Give them some time to contemplate and commit this patch to
    the repo for now.

    PR:             258253
    Reported by:    Alex <marcarianalexandru@gmail.com>
    Reported by:    Marc Flambard <marc-pub@alluem.fr> (by email)

 lang/go/Makefile                                          |  6 +-----
 lang/go/distinfo                                          |  4 +---
 lang/go/files/patch-src_cmd_link_internal_ld_elf.go (new) | 15 +++++++++++++++
 3 files changed, 17 insertions(+), 8 deletions(-)
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2021-09-03 17:18:01 UTC
Thanks for the report!
Comment 3 Alex 2021-09-03 20:37:09 UTC
Thank you!