Bug 258254 - www/chromium: unbreak for i386
Summary: www/chromium: unbreak for i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-chromium (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-03 16:30 UTC by Felix Palmen
Modified: 2021-10-22 10:33 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)

Attachments
unbreak on i386 (2.82 KB, patch)
2021-09-03 16:30 UTC, Felix Palmen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen freebsd_committer 2021-09-03 16:30:27 UTC 
Created attachment 227648 [details]
unbreak on i386

Find attached my suggestion how to unbreak the build for i386 (patch applies with `git am`). The commit message should explain it:

---
www/chromium: unbreak on i386

FreeBSD's sendfile() expects a pointer to off_t for returning the copied
size. Change local variables used to off_t for OS_BSD: if any, this is
wider than the ssize_t used before (on amd64, it's the same).
---

I *think* this change would be correct for any arch, but please challenge/review my reasoning.

Disclaimer: PR created on an old EeePC using the i386 build of chromium 92.0.4515.159_1 -- in the hope the changed code path is actually used for attaching the patch here, but TBH, I have no idea whether this really is the case.

I also needed to increase kern.maxtsiz for running chromium.
Comment 1 Matthias Wolf 2021-10-20 10:54:52 UTC 
Should work on i386 again with v94.
Comment 2 Felix Palmen freebsd_committer 2021-10-22 10:33:48 UTC 
(In reply to Matthias Wolf from comment #1)
Yes, it does.