Bug 258259 - devel/kf5-kio: incomplete dependency on devel/kf5-kdoctools
Summary: devel/kf5-kio: incomplete dependency on devel/kf5-kdoctools
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: freebsd-kde (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-03 19:23 UTC by randombit
Modified: 2021-09-19 07:53 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description randombit 2021-09-03 19:23:26 UTC
repo: 12.2 latest.

kf5-kdoctools is linked as dependency to kf5-kio binary. autoremove removes it with its own dependencies, yet every time running _pkg-upgrade_ all of them gets reinstalled, as listed below:

        docbook: 1.5
	docbook-sgml: 4.5_1
	docbook-xml: 5.0_3
	docbook-xsl: 1.79.1_1,1
	iso8879: 1986_3
	kf5-kdoctools: 5.85.0
	sdocbook-xml: 1.1_2,2
	xmlcatmgr: 2.2_2
	xmlcharent: 0.3_2

------------------------------------------------------------------------------------------------
------------------------------------------------------------------------------------------------
pkg info kf5-kio

kf5-kio-5.85.0
Name           : kf5-kio
Version        : 5.85.0
Installed on   : Tue Aug 24 14:58:57 2021 CEST
Origin         : devel/kf5-kio
Architecture   : FreeBSD:12:amd64
Prefix         : /usr/local
Categories     : kde devel kde-frameworks
Licenses       : LGPL20
Maintainer     : kde@FreeBSD.org
WWW            : http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/index.html
Comment        : KF5 resource and network access abstraction
Shared Libs required:
	libKF5Codecs.so.5
	libQt5Gui.so.5
	libKF5WidgetsAddons.so.5
	libxslt.so.1
	libKF5Archive.so.5
	libKF5TextWidgets.so.5
	libKF5JobWidgets.so.5
	libKF5ItemViews.so.5
	libQt5Concurrent.so.5
	libQt5Qml.so.5
	libxml2.so.2
	libQt5Widgets.so.5
	libKF5DBusAddons.so.5
	libKF5CoreAddons.so.5
	libKF5Auth.so.5
	libKF5ConfigGui.so.5
	libKF5XmlGui.so.5
	libKF5DocTools.so.5
	libKF5ConfigWidgets.so.5
	libKF5ConfigCore.so.5
	libKF5SonnetUi.so.5
	libKF5Notifications.so.5
	libKF5I18n.so.5
	libKF5WindowSystem.so.5
	libKF5Completion.so.5
	libQt5X11Extras.so.5
	libKF5Wallet.so.5
	libQt5Core.so.5
	libQt5Xml.so.5
	libQt5DBus.so.5
	libexslt.so.0
	libKF5Bookmarks.so.5
	libQt5Network.so.5
	libKF5Service.so.5
	libKF5AuthCore.so.5
	libKF5GuiAddons.so.5
	libKF5IconThemes.so.5
	libKF5Solid.so.5
	libKF5Crash.so.5
Shared Libs provided:
	libKF5KIOCore.so.5
	libKF5KIOGui.so.5
	libKF5KIOFileWidgets.so.5
	libKF5KIOWidgets.so.5
	libKF5KIONTLM.so.5
Annotations    :
	FreeBSD_version: 1202000
	repo_type      : binary
	repository     : FreeBSD
Flat size      : 20.8MiB
Description    :
This framework implements almost all the file management functions you will ever
need. In fact, the KDE file manager (Dolphin) and the KDE file dialog also uses
this to provide its network-enabled file management.

WWW: http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/index.html


------------------------------------------------------------------------------------------------
pkg rquery -I kf5-kio

kf5-kio-5.85.0|/usr/ports/devel/kf5-kio|/usr/local|KF5 resource and network access abstraction|/usr/ports/devel/kf5-kio/pkg-descr|kde@FreeBSD.org|kde devel kde-frameworks||qt5-x11extras-5.15.2_1 kf5-kwindowsystem-5.85.0 kf5-kded-5.85.0 qt5-widgets-5.15.2_3 qt5-gui-5.15.2_6 qt5-declarative-5.15.2_3 kf5-kxmlgui-5.85.0 kf5-kwidgetsaddons-5.85.0 kf5-ktextwidgets-5.85.0 kf5-kjobwidgets-5.85.0 kf5-kitemviews-5.85.0 kf5-kconfigwidgets-5.85.0 kf5-kcompletion-5.85.0 kf5-kiconthemes-5.85.0 qt5-xml-5.15.2_1 libxslt-1.1.34_2 libxml2-2.9.12 kf5-sonnet-5.85.0 kf5-kcodecs-5.85.0 kf5-kwallet-5.85.0 qt5-network-5.15.2_1 qt5-script-5.15.2_1 qt5-dbus-5.15.2_1 qt5-core-5.15.2_5 qt5-concurrent-5.15.2_2 kf5-solid-5.85.0 kf5-kservice-5.85.0 kf5-knotifications-5.85.0 kf5-ki18n-5.85.0 kf5-kdbusaddons-5.85.0 kf5-kcrash-5.85.0 kf5-kcoreaddons-5.85.0 kf5-kconfig-5.85.0 kf5-kbookmarks-5.85.0 kf5-kauth-5.85.0 gettext-runtime-0.21 desktop-file-utils-0.26 kf5-karchive-5.85.0|http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/index.html|||

------------------------------------------------------------------------------------------------
pkg rquery %B kf5-kio

libKF5Codecs.so.5
libQt5Gui.so.5
libKF5WidgetsAddons.so.5
libxslt.so.1
libKF5Archive.so.5
libKF5TextWidgets.so.5
libKF5JobWidgets.so.5
libKF5ItemViews.so.5
libQt5Concurrent.so.5
libQt5Qml.so.5
libxml2.so.2
libQt5Widgets.so.5
libKF5DBusAddons.so.5
libKF5CoreAddons.so.5
libKF5Auth.so.5
libKF5ConfigGui.so.5
libKF5XmlGui.so.5
libKF5DocTools.so.5
libKF5ConfigWidgets.so.5
libKF5ConfigCore.so.5
libKF5SonnetUi.so.5
libKF5Notifications.so.5
libKF5I18n.so.5
libKF5WindowSystem.so.5
libKF5Completion.so.5
libQt5X11Extras.so.5
libKF5Wallet.so.5
libQt5Core.so.5
libQt5Xml.so.5
libQt5DBus.so.5
libexslt.so.0
libKF5Bookmarks.so.5
libQt5Network.so.5
libKF5Service.so.5
libKF5AuthCore.so.5
libKF5GuiAddons.so.5
libKF5IconThemes.so.5
libKF5Solid.so.5
libKF5Crash.so.5


------------------------------------------------
Comment 1 Tobias C. Berner freebsd_committer 2021-09-03 19:45:17 UTC
Moin moin 

Indeed it looks like the dependency on doctools was made build-only by mistake in devel/kf5-kio:

====> Running Q/A tests (stage-qa)
Error: /usr/local/lib/libKF5KIOFileWidgets.so.5.85.0 is linked to /usr/local/lib/libKF5GuiAddons.so.5 from x11-toolkits/kf5-kguiaddons but it is not declared as a dependency
Warning: you need USE_KDE+=guiaddons
Error: /usr/local/lib/qt5/plugins/kf5/kio/kio_ghelp.so is linked to /usr/local/lib/libKF5DocTools.so.5 from devel/kf5-kdoctools but it is not declared as a dependency
Warning: you need USE_KDE+=doctools


mfg Tobias
Comment 2 Gleb Popov freebsd_committer 2021-09-17 16:17:57 UTC
diff --git a/devel/kf5-kio/Makefile b/devel/kf5-kio/Makefile
index e9e30041beef..b42f0973c02b 100644
--- a/devel/kf5-kio/Makefile
+++ b/devel/kf5-kio/Makefile
@@ -1,5 +1,6 @@
 PORTNAME=      kio
 DISTVERSION=   ${KDE_FRAMEWORKS_VERSION}
+PORTREVISION=  1
 CATEGORIES=    devel kde kde-frameworks
 
 MAINTAINER=    kde@FreeBSD.org
@@ -9,11 +10,11 @@ USES=                cmake compiler:c++11-lib desktop-file-utils \
                gettext gnome kde:5 qt:5 ssl tar:xz
 USE_GNOME=     libxml2 libxslt
 USE_KDE=       archive auth bookmarks codecs completion config \
-               configwidgets coreaddons crash dbusaddons \
+               configwidgets coreaddons crash dbusaddons guiaddons \
                i18n iconthemes itemviews jobwidgets kded \
                notifications service solid sonnet textwidgets wallet \
                widgetsaddons windowsystem xmlgui \
-               doctools_build ecm_build 
+               doctools ecm_build
 USE_QT=                concurrent core dbus declarative gui network \
                script widgets x11extras xml \
                buildtools_build qmake_build testlib_build


OK to push?
Comment 3 Adriaan de Groot freebsd_committer 2021-09-17 21:26:29 UTC
I'd really rather not; guiaddons is fine, but doctools is **fat** because it pulls in .. all the documentation tooling. One reason I went through pushing doctools to `_build` all over was to avoid those 60MB for everything that could possibly use kio. That's mostly important for "live CD" situations like helloSystem, though.

If we could have subpackages, this would be a no-brainer: put the help: and ghelp: KIO workers in a subpackage which pulls in the doctools. They are of limited use (in the sense that without the help: worker, application help falls back to a web browser pointing at docs.kde.org rather than a local copy).
Comment 4 commit-hook freebsd_committer 2021-09-19 07:53:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2c0f38fb85951f5fa0280353d4342f95f5c55c5c

commit 2c0f38fb85951f5fa0280353d4342f95f5c55c5c
Author:     Gleb Popov <arrowd@FreeBSD.org>
AuthorDate: 2021-09-19 07:49:29 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2021-09-19 07:50:38 +0000

    devel/kf5-kio: Add missing dependency on x11-toolkits/kf5-kguiaddons

    PR:             258259
    Approved by:    adridg

 devel/kf5-kio/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Gleb Popov freebsd_committer 2021-09-19 07:53:33 UTC
Should we close this PR for now?