Created attachment 227687 [details]
v1 (use "git am")
lang/go(-devel) does not respect CC per https://docs.freebsd.org/en/books/porters-handbook/porting-dads/#dads-cc
Reproduce by deleting 'cc' from jail and overriding CC to another value.
Package contents did change; PORTREVISION is bumped for lang/go(-devel):
My 'misc' repository also contains bulk and testport logs for this change,
not adding URL links to specific commits because codeberg did not generate
log diff this time for some reason, diff between logs can also be observed
by cloning the 'misc' repository and viewing with git if needed.
Are environment/user CFLAGS and other flags (LDFLAGS, etc) honoured? Honoured meaning 'appended', not just included
(In reply to Kubilay Kocak from comment #1)
> Are environment/user CFLAGS and other flags (LDFLAGS, etc) honoured?
This is not easily verifiable as lang/go build log is not verbose by default,
and I am not familiar with Go build system to verbose build log. I added
"CFLAGS" and "LDFLAGS" to Makefile to check, and it seems that Go can't
build with these passed:
=======================<phase: build >============================
===== env: NO_DEPENDS=yes
===> Building for go-1.17_3,1
cd /wrkdirs/usr/ports/lang/go/work/go/src ; /usr/bin/env XDG_CACHE_HOME=/wrkdirs/usr/ports/lang/go/work GOROOT_BOOTSTRAP=/wrkdirs/usr/ports/lang/go/work/go-freebsd-amd64-bootstrap GOROOT=/wrkdirs/usr/ports/lang/go/work/go GOROOT_FINAL=/usr/local/go GOBIN= GOOS=freebsd GOARCH=amd64 GO386= GOARM= CC=cc CFLAGS=-O2 -pipe -fstack-protector-foo -fstack-protector-strong -fno-strict-aliasing LDFLAGS= -fstack-protector-strong /bin/sh make.bash -v
env: -pipe: No such file or directory
*** Error code 127
Also, this seems PR scope creep to me.
Created attachment 228168 [details]
v1.1 (use "git am")
Update to the latest ports.