Bug 258292 - mail/neomutt: Respect CC
Summary: mail/neomutt: Respect CC
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
Keywords: needs-qa
Depends on:
Reported: 2021-09-05 18:25 UTC by Evgeniy Khramtsov
Modified: 2021-10-23 17:02 UTC (History)
0 users

See Also:
evgeniy: maintainer-feedback-
koobs: merge-quarterly?

v1 (use "git am") (648 bytes, patch)
2021-09-05 18:25 UTC, Evgeniy Khramtsov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Khramtsov 2021-09-05 18:25:00 UTC
Created attachment 227692 [details]
v1 (use "git am")

mail/neomutt needs to respect CC per https://docs.freebsd.org/en/books/porters-handbook/porting-dads/#dads-cc

Reproduce by deleting 'cc' from jail and overriding CC to another value.

Package contents did not change:

11.4/amd64: https://codeberg.org/ei/misc/commit/eb085f3ba60
11.4/i386:  https://codeberg.org/ei/misc/commit/4ad3ffef396
12.2/amd64: https://codeberg.org/ei/misc/commit/b16c45d9963
12.2/i386:  https://codeberg.org/ei/misc/commit/e1f88aff135
13.0/amd64: https://codeberg.org/ei/misc/commit/6629ac89ec6

Log diff with the patch applied:

11.4/amd64: https://codeberg.org/ei/misc/commit/3b4159a7192
11.4/i386:  https://codeberg.org/ei/misc/commit/c8392642678
12.2/amd64: https://codeberg.org/ei/misc/commit/726ed7004ab
12.2/i386:  https://codeberg.org/ei/misc/commit/9c311e55600
13.0/amd64: https://codeberg.org/ei/misc/commit/7a161f0037f

Testport logs with the patch applied:

11.4/amd64: https://codeberg.org/ei/misc/commit/8a30ca1a975
11.4/i386:  https://codeberg.org/ei/misc/commit/dd7e0c22d3e
12.2/amd64: https://codeberg.org/ei/misc/commit/3284b358fb9
12.2/i386:  https://codeberg.org/ei/misc/commit/82572f8dd21
13.0/amd64: https://codeberg.org/ei/misc/commit/6724a3cf900

13.0/aarch64 QA via qemu-user-static is omitted because the
dependency 'mail/notmuch' can't configure here, maybe a bug?
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-06 02:51:41 UTC
Are environment/user CFLAGS and other flags (LDFLAGS, etc) honoured? Honoured meaning 'appended', not just included
Comment 2 Evgeniy Khramtsov 2021-09-06 11:10:36 UTC
(In reply to Kubilay Kocak from comment #1)

Yes. Checked via "Summary of build options" and build commands from build log:
---Begin make.conf---
#### /usr/local/etc/poudriere.d/130-amd64-make.conf ####

-CFlags:                -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -std=c99 -D_ALL_SOURCE=1 -D_GNU_SOURCE=1 -D__EXTENSIONS__ -I/usr/local/include -DNCURSES_WIDECHAR -I/usr/include -I/usr/include
-CFlags:                -O2 -pipe -O0  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -std=c99 -D_ALL_SOURCE=1 -D_GNU_SOURCE=1 -D__EXTENSIONS__ -I/usr/local/include -DNCURSES_WIDECHAR -I/usr/include -I/usr/include
-LDFlags:                -fstack-protector-strong  -L/usr/local/lib -L/usr/lib -L/usr/lib -lgssapi -lgssapi_krb5 -lheimntlm -lkrb5 -lhx509 -lcom_err -lcrypto -lasn1 -lwind -lheimbase -lroken -lcrypt -pthread
+LDFlags:                -Wl,--as-needed  -fstack-protector-strong  -L/usr/local/lib -L/usr/lib -L/usr/lib -lgssapi -lgssapi_krb5 -lheimntlm -lkrb5 -lhx509 -lcom_err -lcrypto -lasn1 -lwind -lheimbase -lroken -lcrypt -pthread

> needs-qa

Can you clarify what QA does this change need? This port does not have consumers
and I already did QA on Tier 1 platforms and made sure that the package contents did not change. "CC_FOR_BUILD" is also used by many ports, e.g. ports-mgmt/pkg.
Comment 3 Evgeniy Khramtsov 2021-09-21 15:01:03 UTC
Maintainer timeout.
Comment 4 Evgeniy Khramtsov 2021-10-03 13:47:42 UTC
Comment 5 Evgeniy Khramtsov 2021-10-23 17:02:50 UTC