Bug 258313 - graphics/proj: Update to 8.2.1
Summary: graphics/proj: Update to 8.2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on: 259682 259818 259845
Blocks:
  Show dependency treegraph
 
Reported: 2021-09-06 11:18 UTC by Darcy Buskermolen
Modified: 2022-01-05 07:12 UTC (History)
6 users (show)

See Also:
lbartoletti: maintainer-feedback+


Attachments
graphics/proj: Update to 8.2.0 (22.44 KB, patch)
2021-11-06 08:15 UTC, Loïc Bartoletti
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darcy Buskermolen 2021-09-06 11:18:48 UTC
Proj 8.1.1 was released, updating the EPSG database as well of a number of bug fixes.

https://proj.org/news.html#release-notes

Updates
EPSG Database updated to version 10.028 (#2773)

Bug Fixes
Include algorithm header file to avoid build errors on Alpine Linux (#2769)

CMake: fix installation of executables on iOS (#2766)

Associate extents to transformations of CRS’s that include GEOIDMODEL (#2769)

Logging: avoid some overhead when logging is not enabled (#2775)

ortho: remove useless and invalid log trace (#2777)

CMake: remove external nlohmann_json from INTERFACE_LINK_LIBRARIES target (#2781)

reateOperations(): fix SourceTargetCRSExtentUse::NONE mode (#2783)

GeoTIFF grid reading: perf improvements (#2788)

Conversion::createUTM(): avoid integer overflow (#2796)

Inverse laea ellipsoidal: return PROJ_ERR_COORD_TRANSFM_OUTSIDE_PROJECTION_DOMAIN when appropriates (#2801)

Make sure that proj_crs_promote_to_3D() returns a derived CRS (#2806)

createOperations(): fix missing deg<–>rad conversion when transforming with a CRS that has a fallback-to-PROJ4-string behaviour and is a BoundCRS of a GeographicCRS (#2808)

WKT2 import/export: preserve PROJ.4 CRS extension string in REMARKS[] (#2812)

BoundCRS: accept importing/exporting in WKT2 and PROJJSON the scope/area/extent/id attributes (#2815)

ConcatenatedOperation::fixStepsDirection(): fix bad chaining of steps when inverse map projection is involved in non-final step (#2819)
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2021-09-18 08:36:00 UTC
Unfortunately, last time I checked, some ports are not ready to proj 8.x

I'll try to patch them soon.
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2021-11-06 08:15:54 UTC
Created attachment 229313 [details]
graphics/proj: Update to 8.2.0

Here is the patch to update proj to 8.2.0

As mentioned before, unfortunately, some ports are broken by this update. Maybe it's time to clean up or update these ports?

Failed ports:
graphics/librasterlite	configure (deprecated, to be removed)
devel/libght	check-plist (maybe unrelated)
databases/postgis24	lib-depends (deprecated upstream soon)
graphics/py-cartopy	build (must be updated to 0.20.x ?)
astro/merkaartor	build (to be fixed)
graphics/opencv	fetch (maybe unrelated)
graphics/openorienteering-mapper	configure (must be updated to 0.9.5 I guess)
databases/postgis25	configure (to be fixed or deprecated. IDK yet)
science/gnudatalanguage	build (Try this fix https://github.com/gnudatalanguage/gdl/commit/a9ce82083f04fdd4071513497508105dbe5581a6)
math/octave-forge-octproj	build (maybe fixed in 2.0.1)

Skipped ports:
graphics/libreatlas	librasterlite (deprecated, to be removed)
multimedia/lives	opencv
math/saga	opencv

The logs (with the diff) are available here: https://people.freebsd.org/~lbartoletti/logs/proj8/

And my branch on GH, if you want to contribute: https://github.com/lbartoletti/freebsd-ports/tree/proj8
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-11-06 13:10:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=70ff20610d9d2444d97f0f9555f8bc2df6e384a3

commit 70ff20610d9d2444d97f0f9555f8bc2df6e384a3
Author:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
AuthorDate: 2021-11-06 12:46:09 +0000
Commit:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
CommitDate: 2021-11-06 12:48:08 +0000

    graphics/librasterlite: Deprecate port and set expiration date to 2021-12-31

    PR:             258313

 graphics/librasterlite/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-11-06 13:10:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e1f55c067b5bdeaa62440d1b4e85e031f5f5c0d6

commit e1f55c067b5bdeaa62440d1b4e85e031f5f5c0d6
Author:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
AuthorDate: 2021-11-06 12:47:11 +0000
Commit:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
CommitDate: 2021-11-06 12:48:09 +0000

    graphics/libreatlas: Deprecate port and set expiration date to 2021-12-31

    PR:             258313

 graphics/libreatlas/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 5 Oliver Heesakkers 2021-11-06 13:57:35 UTC
Dropping

CFLAGS+=	"-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1"

from the astro/merkaartor Makefile should suffice. Merkaartor 0.19 is known to build successfully with Proj 8 on (an)other platform(s)
Comment 6 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2021-11-06 16:36:34 UTC
Since going from proj version 7 to version 8 is such a big change, how about splitting it into two ports.  Say called proj7 and proj.  Or proj and proj8.  That way, ports can catch up over time.
Comment 7 Rainer Hurling freebsd_committer freebsd_triage 2021-11-06 18:42:38 UTC
Hi Loïc,

I just prepared bug #259682 for the update of graphics/py-cartopy to v0.20.1, which seems to solve the breakage with graphics/proj v8.2.0.


BTW, the fetch problem with graphics/opencv is not reproducible for me. 

And, math/saga seems to build and install fine with Proj 8.2.0 ;)
Comment 8 Loïc Bartoletti freebsd_committer freebsd_triage 2021-11-07 12:21:08 UTC
(In reply to Stephen Montgomery-Smith from comment #6)

I don't think 7 to 8 is a great deal. IMHO, it was complicated for 4->7 but not for 7->8.
The main problem if we have proj7 and proj8 it's that we have to handle with conflicts between binaries
Comment 9 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2021-11-07 17:43:45 UTC
(In reply to Loïc Bartoletti from comment #8)

I made changes to math/octave-forge-octproj so that it will build with proj version 8.

It was difficult to figure out, because it seems that #include<proj.h> is depreciated, but that is what the current proj docs tell you to do.
Comment 10 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2021-11-07 19:53:13 UTC
(In reply to Stephen Montgomery-Smith from comment #9)
Now I have figured out the proper fix to math/octave-forge-octproj in commit a277131e9bc3bfb58e537cd15c2e44ab66902562.
Comment 11 commit-hook freebsd_committer freebsd_triage 2021-11-13 06:56:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1f45cbf49afcbea6c5234e196863514520c18764

commit 1f45cbf49afcbea6c5234e196863514520c18764
Author:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
AuthorDate: 2021-11-13 06:30:51 +0000
Commit:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
CommitDate: 2021-11-13 06:32:45 +0000

    databases/postgis2{4,5}: Deprecate port

    PR:     258313

 databases/postgis24/Makefile | 3 +++
 databases/postgis25/Makefile | 3 +++
 2 files changed, 6 insertions(+)
Comment 12 Loïc Bartoletti freebsd_committer freebsd_triage 2021-11-13 14:10:59 UTC
thierry@

science/gnudatalanguage: Simply remove the CFLAGS "-DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1"
see bug #259818
Comment 13 commit-hook freebsd_committer freebsd_triage 2021-11-18 05:41:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=740130cd7038d1c61b0da0c44615d986e5d865f7

commit 740130cd7038d1c61b0da0c44615d986e5d865f7
Author:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
AuthorDate: 2021-11-18 05:17:26 +0000
Commit:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
CommitDate: 2021-11-18 05:17:26 +0000

    science/gnudatalanguage: prepare to proj8

      - remove -DACCEPT_USE_OF_DEPRECATED_PROJ_API_H=1

    PR:             259818, 258313
    Approved by:    thierry (maintainer)

 science/gnudatalanguage/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 14 commit-hook freebsd_committer freebsd_triage 2022-01-05 07:10:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3135e8e9bbab2e19553578231e49d2920bfc6411

commit 3135e8e9bbab2e19553578231e49d2920bfc6411
Author:     Rainer Hurling <rhurlin@FreeBSD.org>
AuthorDate: 2022-01-05 06:01:21 +0000
Commit:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
CommitDate: 2022-01-05 06:08:24 +0000

    graphics/py-cartopy: Update to 0.20.1

    - Update to 0.20.1 and build against graphics/proj v8
    - Add dependency graphics/py-pyproj for coordinate transformations,
      which added support for building with Proj 8.

    Changes:
      - https://github.com/SciTools/cartopy/compare/v0.19.0.post1...v0.20.1

    PR:             259682, 258313
    Reported by:    rhurlin
    Approved by:    maintainer (timeout)

 graphics/py-cartopy/Makefile | 10 +++-------
 graphics/py-cartopy/distinfo |  6 +++---
 2 files changed, 6 insertions(+), 10 deletions(-)
Comment 15 commit-hook freebsd_committer freebsd_triage 2022-01-05 07:10:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0435aedaaac66a70be35c3180225f0d1d8cfec68

commit 0435aedaaac66a70be35c3180225f0d1d8cfec68
Author:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
AuthorDate: 2022-01-04 20:55:07 +0000
Commit:     Loïc Bartoletti <lbartoletti@FreeBSD.org>
CommitDate: 2022-01-05 06:08:24 +0000

    graphics/proj: Update to 8.2.1

    This release update the EPSG database as well of a number of bug fixes
    and remove the deprecated API.

    Changes:
      - https://proj.org/news.html#release-notes

    PR:             258313
    Reported by:    darcy@dbitech.ca
    Reviewed by:    stephen, rhurlin

 graphics/proj/Makefile  |  11 +-
 graphics/proj/distinfo  |  22 +--
 graphics/proj/pkg-plist | 445 ++++++++++++++++++++++++++++++++++--------------
 3 files changed, 335 insertions(+), 143 deletions(-)
Comment 16 Loïc Bartoletti freebsd_committer freebsd_triage 2022-01-05 07:12:42 UTC
Committed, thanks!