Bug 258340 - devel/msgpack: Separate C and CXX packages
Summary: devel/msgpack: Separate C and CXX packages
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-07 15:17 UTC by Adam Weinberger
Modified: 2022-10-16 21:13 UTC (History)
0 users

See Also:
adamw: exp-run?


Attachments
4.0.0 (61.83 KB, patch)
2021-09-07 15:17 UTC, Adam Weinberger
no flags Details | Diff
4.0.3 (57.29 KB, patch)
2021-12-12 23:53 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2021-09-07 15:17:49 UTC
Created attachment 227736 [details]
4.0.0

msgpack 4.0.0 completely separates C and CXX, with separate distfiles. The CXX package is header-only and requires boost.

It's not totally clear to me which ports will want C vs CXX, so I figure a limited exp-run might be the easiest path. The attached patch switches things to msgpack-c; if they fail to build, they probably wanted CXX.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2021-09-09 14:14:48 UTC
The msgpack line has to be removed from devel/Makefile
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2021-09-09 14:15:18 UTC
And a msgpack-c line has to be added
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2021-12-12 23:53:33 UTC
Created attachment 230069 [details]
4.0.3

This updates msgpack versions, fixes devel/Makefile, and attempts to fix the broken ports. Can you please give this one more run? Thanks for the help!
Comment 6 Baptiste Daroussin freebsd_committer freebsd_triage 2022-08-26 08:38:59 UTC
should we close this one?
Comment 7 Adam Weinberger freebsd_committer freebsd_triage 2022-09-04 16:38:16 UTC
(In reply to Baptiste Daroussin from comment #6)
Upstream msgpack is at 4.1.1 now, but our port is still stuck at 3.3.0.

It still needs to be split, but I'm now sure how to fix the opendht error it produces (a new run at 4.1.1 may well have different failures).
Comment 8 Adam Weinberger freebsd_committer freebsd_triage 2022-10-16 21:13:39 UTC
Well, I completely forgot to mention this PR in the commit, but I've fixed up the rest of the stuff and committed something based on this. Thanks everyone for the exp-runs!