Bug 258373 - devel/simdjson: update to 1.0.0
Summary: devel/simdjson: update to 1.0.0
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/simdjson/simdjson/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-08 19:16 UTC by Oleg Ginzburg
Modified: 2021-09-09 13:35 UTC (History)
1 user (show)

See Also:


Attachments
devel/simdjson: update to 1.0.0 (1.62 KB, patch)
2021-09-08 19:16 UTC, Oleg Ginzburg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Ginzburg 2021-09-08 19:16:18 UTC
Created attachment 227769 [details]
devel/simdjson: update to 1.0.0

changes: https://github.com/simdjson/simdjson/releases/tag/v1.0.0
Comment 1 Nuno Teixeira freebsd_committer 2021-09-09 13:34:52 UTC
Hello,

1. Makefile says:
---
BROKEN_i386=    does not build (error: unknown type name '__uint128_t')
---

Poudriere tests at https://people.freebsd.org/~eduardo/logs/simdjson-1.0.0/ compiles ok on i386 with a warning:
---
warning: The simdjson library is designed for 64-bit processors and it seems that you are not compiling for a known 64-bit platform. All fast kernels will be disabled and performance may be poor. Please use a 64-bit target such as x64, 64-bit ARM or 64-bit PPC. [-W#pragma-messages]
---

Maybe upstream have done some compatibily with i386?

2. Small order fix (from portclippy):

Move "CXXFLAGS_powerpc64" to CFLAGS/CXXFLAGS/LDFLAGS block:

---
# PORTNAME block
PORTNAME
DISTVERSIONPREFIX
DISTVERSION
CATEGORIES

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE
LICENSE_FILE

# BROKEN/IGNORE/DEPRECATED messages
BROKEN_i386

-CXXFLAGS_powerpc64 <==

# USES block
USES
USE_GITHUB
USE_LDCONFIG

# USES=cmake related variables
CMAKE_ON

# CFLAGS/CXXFLAGS/LDFLAGS block
+CXXFLAGS_powerpc64 <==
---

Could you test this on i386?