During an exp-run for llvm 13 (see bug 258209), it turned out that biology/jellyfish fails to build with clang 13 :
In file included from sub_commands/count_main.cc:38:
In file included from ./include/jellyfish/hash_counter.hpp:16:
./include/jellyfish/dumper.hpp:48:24: error: variable 'mode' set but not used [-Werror,-Wunused-but-set-variable]
std::ios::openmode mode = std::ios::out;
1 error generated.
This is an actual bug: the mode variable is setup in the dumper_t::open_next_file() function, but never used for actually opening the output file.
Fix this by adding the mode argument to the out.open() call.
Created attachment 227798 [details]
Fix unused mode variable
A commit in branch main references this bug:
Author: Jason W. Bacon <jwb@FreeBSD.org>
AuthorDate: 2021-09-11 12:29:47 +0000
Commit: Jason W. Bacon <jwb@FreeBSD.org>
CommitDate: 2021-09-11 12:29:47 +0000
biology/jellyfish: Fix unused open mode variable
Reported by: dim
biology/jellyfish/Makefile | 1 +
.../jellyfish/files/patch-include_jellyfish_dumper.hpp (new) | 11 +++++++++++
2 files changed, 12 insertions(+)