Bug 258407 - editors/vim: vim@console and vim@tiny is not truly console/tiny
Summary: editors/vim: vim@console and vim@tiny is not truly console/tiny
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Adam Weinberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-10 15:48 UTC by Michael Osipov
Modified: 2021-09-13 08:09 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (adamw)


Attachments
Patch for Makefile (383 bytes, patch)
2021-09-10 15:48 UTC, Michael Osipov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov 2021-09-10 15:48:36 UTC
Created attachment 227808 [details]
Patch for Makefile

If flavors tiny or console are used you expect that no X is involved. Unfortunately, the port does not properly handle that:
* The configure option says:
>  --enable-gui=OPTS       X11 GUI. default=auto OPTS=auto/no/gtk2/gnome2/gtk3/motif/athena/neXtaw/haiku/photon/carbon
So it is still X11
* If you have X11 installed, e.g., for Wireshark, it will still link with X11 no matter what

To make is truly tiny/console you MUST pass --without-x.

Attached is a patch which addresses this for tiny and console for me.
Comment 1 Adam Weinberger freebsd_committer 2021-09-11 15:58:08 UTC
Good catch!
Comment 2 Michael Osipov 2021-09-13 08:09:32 UTC
(In reply to Adam Weinberger from comment #1)

Thanks looking forward to a commit. Hopefully before the next quarterly branch.