Bug 258445 - sysutils/cpuid2cpuflags: Only allow amd64 and i386 archs
Summary: sysutils/cpuid2cpuflags: Only allow amd64 and i386 archs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL: https://github.com/mgorny/cpuid2cpufl...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-12 10:35 UTC by Daniel Engberg
Modified: 2022-05-17 08:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)
koobs: merge-quarterly?


Attachments
Patch for cpuid2cpuflags (716 bytes, patch)
2021-09-12 10:35 UTC, Daniel Engberg
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-09-12 10:35:06 UTC
Created attachment 227847 [details]
Patch for cpuid2cpuflags

Fails on all other platforms and is unsupported upstream

Reported by pkg-fallout
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-12 10:48:31 UTC
Comment on attachment 227847 [details]
Patch for cpuid2cpuflags

Approved by: portmgr (build fix, ports compliance)
MFH: 2020Q3
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2021-09-13 00:18:15 UTC
(In reply to Daniel Engberg from comment #0)
> Fails on all other platforms and is unsupported upstream
At least ARM and PowerPC should be supported; if it fails on FreeBSD, I reckon we should try to fix it rather than simply mark the port as x86-only.  I'll see if I can use our cluster ARM machines to play with it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-05-17 07:53:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3951881016b76468ed9e558b26e23ab3d2a4d3db

commit 3951881016b76468ed9e558b26e23ab3d2a4d3db
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2022-05-17 07:53:14 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2022-05-17 07:53:14 +0000

    sysutils/cpuid2cpuflags: make the port build and work on ARM

    - Replace getauxval(3), a non-standard glibc extension, with
      our native elf_aux_info(3) call
    - Return features supported by the specific machine processor
      architecture (uname -p) rather than the hardware platform
      (uname -m), because the latter is too vague on FreeBSD/arm

    PR:             258445
    Reported by:    pkg-fallout

 .../cpuid2cpuflags/files/patch-src_hwcap.c (new)   | 48 ++++++++++++++++++++++
 1 file changed, 48 insertions(+)
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-05-17 08:30:32 UTC
Should be fixed at least on ARM now, I could not test on PowerPC at the moment.  With upstream being notified (via GitHub issue), I think we can close this PR.