Created attachment 227881 [details] patch
I have that update already for some time ready: https://gitlab.fechner.net/mfechner/Gitlab/-/commit/183e10ff6d9afac57cafbeff6b3d5bdb7d6aaf36 But it will causes some ports like gitlab-ce to stop working. Lets wait for the next gitlab-ce upgrade, maybe it is ready to switch to version 1.2.
Ok.
Hi Matthias, Porter's Handbook recommends you to use USE_GITHUB instead of working around it using MASTER_SITES. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-description (Example 17) Best regards, Daniel
(In reply to Daniel Engberg from comment #3) Hi Daniel, yes, but if you use what the Handbook recommends you use a version that can change the checksum if github is modifing something like compression. If you use the archive, the checksum will never change. The new gitlab-ce version 14.3 does not support this libgit2 version yet.
Hi, The link you're using isn't a static file so that might change aswell?
fwiw, 1.3.0 is out
Created attachment 228306 [details] Patch for libgit2 (1.3.0) Update port to 1.3.0 Use DISTVERSION and USE_GIT to follow Porter's Handbook more closely Use PCRE2 by default instead of PCRE(1) Use http-parser library from ports rather than bundled version as per recommendation in Porter's Handbook Import patch to remove incompatible tests Reference: https://github.com/archlinux/svntogit-packages/blob/packages/libgit2/trunk/libgit2-1.2.0-remove_http-parse_incompatible_tests.patch (see commit history) Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist, make test) Poudriere testport OK 12.2-RELEASE
Thanks Daniel, I included it here in the pipeline: https://gitlab.fechner.net/mfechner/Gitlab/-/commits/libgit2_1.3.0 The moment gitlab and other ports are compatible with this version, I will commit it: https://pkg.fechner.net/build.html?mastername=130amd64-gitlab&build=2021-10-01_15h42m26s
Thanks! If I understand upstream correctly we should be using pygit 1.7.0 (not released yet) with this version or at least that seems what upstream is using to test 1.3.0 series.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=5c8d1c24f8622f77acc3b999bf5c58ed63ea9c61 commit 5c8d1c24f8622f77acc3b999bf5c58ed63ea9c61 Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2021-10-01 13:34:48 +0000 Commit: Matthias Fechner <mfechner@FreeBSD.org> CommitDate: 2021-12-04 12:07:23 +0000 devel/libgit2: Update to 1.3.0 Use DISTVERSION and USE_GIT to follow Porter's Handbook more closely Use PCRE2 by default instead of PCRE(1) Use http-parser library from ports rather than bundled version as per recommendation in Porter's Handbook Import patch to remove incompatible tests Reference: https://github.com/archlinux/svntogit-packages/blob/packages/libgit2/trunk/libgit2-1.2.0-remove_http-parse_incompatible_tests.patch (see commit history) PR: 258484 devel/libgit2/Makefile | 16 +-- devel/libgit2/distinfo | 6 +- .../files/patch-tests_network_url_parse.c (new) | 116 +++++++++++++++++++++ devel/libgit2/pkg-plist | 6 +- 4 files changed, 134 insertions(+), 10 deletions(-)
Commited, thanks!