Bug 258488 - net/rabbitmq: fix pidfile in rabbitmq rc.d script
Summary: net/rabbitmq: fix pidfile in rabbitmq rc.d script
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-erlang (Nobody)
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-09-14 00:04 UTC by Oleg Ginzburg
Modified: 2021-09-14 06:29 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (erlang)
koobs: maintainer-feedback? (dch)
koobs: merge-quarterly?


Attachments
net/rabbitmq: fix pidfile in rabbitmq rc.d script (1.49 KB, patch)
2021-09-14 00:04 UTC, Oleg Ginzburg
no flags Details | Diff
net/rabbitmq: fix pidfile in rabbitmq rc.d script (1.50 KB, patch)
2021-09-14 06:29 UTC, Oleg Ginzburg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Ginzburg 2021-09-14 00:04:05 UTC
Created attachment 227887 [details]
net/rabbitmq: fix pidfile in rabbitmq rc.d script

with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256686 update we got regression related to empty pid file, due to:

https://www.rabbitmq.com/rabbitmq-server.8.html:

-detached
    Start the server process in the background. Note that this will cause the pid not to be written to the pid file


I suggest going back to running through the daemon(8), patch attached.

PS: Also, we return a zero code on stop/shutdown: it affects some management systems that expect a positive code.
Comment 1 Oleg Ginzburg 2021-09-14 06:29:21 UTC
Created attachment 227890 [details]
net/rabbitmq: fix pidfile in rabbitmq rc.d script

use return insead of exit