Bug 258489 - Update net/drawterm to use maintained 9front fork
Summary: Update net/drawterm to use maintained 9front fork
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Robert Clausecker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-14 01:36 UTC by pete
Modified: 2023-11-19 15:07 UTC (History)
5 users (show)

See Also:
winston: maintainer-feedback+


Attachments
Diff to use 9front git snapshot for drawterm (2.11 KB, patch)
2021-09-14 01:36 UTC, pete
no flags Details | Diff
Patch for drawterm (WIP) (1.94 KB, patch)
2021-09-27 21:37 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pete 2021-09-14 01:36:51 UTC
Created attachment 227888 [details]
Diff to use 9front git snapshot for drawterm

This patch updates net/drawterm (the Plan9 remote GUI application) to use a fork maintained by the 9front project.  From the forks description:

This is a fork of Russ Cox's drawterm to incorporate features
from Plan9front (http://9front.org), most importantly DP9IK
authentication support (see authsrv(6)) and the TLS based rcpu(1)
protocol.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-09-15 21:35:49 UTC
Thanks for your patch, looking at OpenBSD it seems like there are issues pulling directly from their git server
https://openports.se/plan9/drawterm
Comment 2 pete 2021-09-16 02:46:06 UTC
Interesting.  I've tested a couple times on my system and running "make makesum" multiple times and I seem to get the same file and checksum info.  It also matches the checksum's from when I filed the PR yesterday.  I also tested on a couple difference systems and didn't run into the issue the OpenBSD maintainers ran into.

If we are worried about being bit by this before updating I'm happy to reach out to their maintainer.
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-09-16 11:40:09 UTC
Yeah, it seems to be fixed now as with their mercurial repo which offers a tar.bz2 archive that's slightly smaller.
https://code.9front.org/hg/drawterm/rev/c034918fcf09

Best regards,
Daniel
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-09-27 21:35:56 UTC
I'm (now) running into the issue mentioned over at OpenBSD's repo.
We're probably going to have the same issue with their hg repo.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2021-09-27 21:37:57 UTC
Created attachment 228219 [details]
Patch for drawterm (WIP)

Tidy up a few things to make portlint happy
Comment 6 winston 2021-10-26 02:48:01 UTC
Hello, changes look good.  I'm interested in finding a new maintainer for this port, or orphaning it, whichever is easier.  I am unable to provide further ports maintenance at this time.

I've reached out directly to see if Pete's interested in taking over maintainership.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2022-02-12 09:05:30 UTC
Hi,

Thanks for follow up, I'll mark this port as deprecated and as exp date unless we hear from Pete.

Best regards,
Daniel
Comment 8 pete 2022-02-14 17:52:30 UTC
Hello, I am sorry this fell of my plate.  I'm happy to take over maintainership for this port as I still hack around on 9front.  I'll start that process today.
Comment 9 pete 2022-02-14 18:01:59 UTC
filed this ticket for Maintainership:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261950
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2023-11-12 03:37:52 UTC
@diizzy any progress on this one?
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2023-11-18 06:17:35 UTC
Hey Pete, are you still working on this patch?

If not, I'd go and give it a try myself.  I want to do some 9front hacking and found our drawterm port to be woefully out of date.
Comment 12 commit-hook freebsd_committer freebsd_triage 2023-11-18 20:24:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e893333a049fb65a595afff686694dda1e40f35c

commit e893333a049fb65a595afff686694dda1e40f35c
Author:     Robert Clausecker <fuz@FreeBSD.org>
AuthorDate: 2023-11-18 06:53:25 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2023-11-18 20:20:44 +0000

    net/drawterm: update to 20230903

     - switch to maintained 9front fork
     - rework and simplify port
     - install man page
     - grab maintainership as maintainer wants to hand it over

    PR:             258489

 net/drawterm/Makefile                          | 26 +++++++++++---------------
 net/drawterm/distinfo                          |  5 +++--
 net/drawterm/files/patch-Make.freebsd (new)    | 22 ++++++++++++++++++++++
 net/drawterm/files/patch-Make.pthread (gone)   | 22 ----------------------
 net/drawterm/files/patch-include_unix.h (gone) | 12 ------------
 5 files changed, 36 insertions(+), 51 deletions(-)
Comment 13 Robert Clausecker freebsd_committer freebsd_triage 2023-11-18 20:29:21 UTC
I've pushed an update to the current 9front fork as there seemed to be consensus that that's a good idea, but the submitter didn't proceed with the patch.

If you would like to have the port changed to something else, keep maintainership or assign it to pete instead, please let me know and I can arrange that.
Comment 14 pete 2023-11-19 15:07:01 UTC
(In reply to Robert Clausecker from comment #11)
Please by all means you can take over this port, I've been overcome by other events.