Bug 258498 - [RESTORE PORT] sysutils/roottail: update to 1.3
Summary: [RESTORE PORT] sysutils/roottail: update to 1.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-14 14:49 UTC by Boris Korzun
Modified: 2021-10-02 23:16 UTC (History)
4 users (show)

See Also:


Attachments
roottail.patch (2.24 KB, patch)
2021-09-14 14:49 UTC, Boris Korzun
no flags Details | Diff
roottail.diff (3.11 KB, patch)
2021-09-14 14:50 UTC, Boris Korzun
no flags Details | Diff
roottail.patch (8.90 KB, patch)
2021-09-20 07:36 UTC, Boris Korzun
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Korzun 2021-09-14 14:49:11 UTC
Created attachment 227896 [details]
roottail.patch

Restore port from ports r534093.

Update to 1.3, fixed fetch-path.
Comment 1 Boris Korzun 2021-09-14 14:50:01 UTC
Created attachment 227897 [details]
roottail.diff
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2021-09-17 06:51:02 UTC
Unless the original maintainer agrees, we usually want a new maintainer to take care of the re-added port. Do you want to be the maintainer of this port?
Comment 3 Boris Korzun 2021-09-17 06:56:19 UTC
(In reply to Li-Wen Hsu from comment #2)

Yep, I can.
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-09-17 08:53:24 UTC
Please use DISTVERSION instead of PORTVERSION
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming (5.2.2)

WWW link is dead, should be http://software.schmorp.de/pkg/root-tail.html

We also probably want this patch
https://salsa.debian.org/debian/root-tail/-/tree/master/debian/patches
...and the rest in
https://src.fedoraproject.org/rpms/root-tail/tree/rawhide except root-tail-1.3-Allow-overriding-LDFLAGS-from-the-command-line.patch (or a combination of both)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2021-09-17 08:55:27 UTC
..and why not call it root-tail as upstream?
Comment 6 Boris Korzun 2021-09-20 07:36:34 UTC
Created attachment 228043 [details]
roottail.patch

(In reply to Daniel Engberg from comment #4)

I've replaced PORTVERSION to DISTVERSION. Changed WWW Link.
I've added four patches from the reps also.

But I've left old portname for backward compatibility.
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2021-09-20 21:25:31 UTC
Hi Boris,

Can you reference what patches you applied so we can document it to make the process easier next time we need update?

Best regards,
Daniel
Comment 8 Boris Korzun 2021-09-20 21:48:14 UTC
(In reply to Daniel Engberg from comment #7)

Yep, of course.

- do-not-chown-manually.patch ( https://salsa.debian.org/debian/root-tail/-/blob/master/debian/patches/do-not-chown-manually.patch )
- fix-linker-and-compiler-options.patch ( https://salsa.debian.org/debian/root-tail/-/blob/master/debian/patches/fix-linker-and-compiler-options.patch )
- root-tail-1.3-Generate-Expose-events-when-clearing-a-window.patch ( https://src.fedoraproject.org/rpms/root-tail/blob/rawhide/f/root-tail-1.3-Generate-Expose-events-when-clearing-a-window.patch )
- root-tail-1.3-Respect-width-and-height-unsigness-in-arithmetics.patch ( https://src.fedoraproject.org/rpms/root-tail/blob/rawhide/f/root-tail-1.3-Respect-width-and-height-unsigness-in-arithmetics.patch )
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-10-02 23:15:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b86a22f00dd1e0c507b160e91feb78d06c58f4d8

commit b86a22f00dd1e0c507b160e91feb78d06c58f4d8
Author:     Boris Korzun <drtr0jan@yandex.ru>
AuthorDate: 2021-10-02 23:11:11 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2021-10-02 23:14:43 +0000

    sysutils/root-tail: Resurrect port, Print text directly to X11 root window

    Simple utility to tail files/logs to a root X window.
    Useful for keeping tabs on log files in X without having
    an additional terminal window open.

    Removed in commit 0786acb3155523a38d1442f3c16ca56750f1db04 due to
    being expired. It previously used roottail but is now
    using root-tail to follow upstream naming.

    Additional patches obtained from Debian and Fedora repositories

    Sources:
    https://salsa.debian.org/debian/root-tail/-/blob/master/debian/patches/do-not-chown-manually.patch
    https://salsa.debian.org/debian/root-tail/-/blob/master/debian/patches/fix-linker-and-compiler-options.patch
    https://src.fedoraproject.org/rpms/root-tail/blob/rawhide/f/root-tail-1.3-Generate-Expose-events-when-clearing-a-window.patch
    https://src.fedoraproject.org/rpms/root-tail/blob/rawhide/f/root-tail-1.3-Respect-width-and-height-unsigness-in-arithmetics.patch

    PR:             258498
    Approved by:    arrowd (mentor)
    Differential Revision:  https://reviews.freebsd.org/D32032

 MOVED                                            |   2 +-
 sysutils/Makefile                                |   1 +
 sysutils/root-tail/Makefile (new)                |  19 ++++
 sysutils/root-tail/distinfo (new)                |   3 +
 sysutils/root-tail/files/patch-Makefile (new)    |  41 ++++++++
 sysutils/root-tail/files/patch-root-tail.c (new) | 126 +++++++++++++++++++++++
 sysutils/root-tail/pkg-descr (new)               |   5 +
 7 files changed, 196 insertions(+), 1 deletion(-)
Comment 10 Daniel Engberg freebsd_committer freebsd_triage 2021-10-02 23:16:51 UTC
Committed with a few minor modifications, thanks!