Bug 258507 - textproc/htmldoc: Update to 1.9.12
Summary: textproc/htmldoc: Update to 1.9.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL: https://www.msweet.org/blog/2021-05-1...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-14 21:13 UTC by Robert Clausecker
Modified: 2021-10-14 20:06 UTC (History)
6 users (show)

See Also:
fuz: maintainer-feedback+
koobs: merge-quarterly?


Attachments
textproc/htmldoc: update to 1.9.12 (2.93 KB, patch)
2021-09-14 21:13 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2021-09-14 21:13:06 UTC
Created attachment 227906 [details]
textproc/htmldoc: update to 1.9.12

Update textproc/htmldoc to 1.9.12

Changelogs:

https://www.msweet.org/blog/2021-05-17-htmldoc-1.9.12.html
https://www.msweet.org/blog/2020-12-24-htmldoc-1.9.11.html
https://www.msweet.org/blog/2020-09-05-htmldoc-1.9.10.html
https://www.msweet.org/blog/2020-06-11-htmldoc-1.9.9.html
https://www.msweet.org/blog/2020-02-15-htmldoc-1.9.8.html
https://www.msweet.org/blog/2019-10-09-htmldoc-1.9.7.html
https://www.msweet.org/blog/2019-09-25-htmldoc-1.9.6.html
https://www.msweet.org/blog/2019-01-23-htmldoc-1.9.5.html
https://www.msweet.org/blog/2018-08-31-htmldoc-1.9.4.html

While we are at it:

 - fix a wrong line break in USES that lead to wrong X11 use
 - move USE=jpeg back to being mandatory because it appears to be
   needed even if HTMLDOCGUI is off
 - make pkgconfig unconditional because it is needed even if
   gnutls is not used
 - remove arm64 pre-build as it doesn't seem to be needed (perhaps
   ndowens knows more; he added it)
 - remove a PPC patch by pkubaj as it no longer applies.  Please
   check if the port still builds on PPC.

Tested with Poudriere on armv7 arm64 i386 amd64 FreeBSD 13.0-RELEASE.

Maintainer appears to be unresponsive and has not replied to previous PRs about this port (e.g. bug #237515, bug #223721, and others; actually the last one were the maintainer responded was bug #106715 from 2006).  Am willing to take over maintainership if desired.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-09-15 21:30:13 UTC
Thanks, does upstream release archive work?
https://github.com/michaelrsweet/htmldoc/releases
Looks good otherwise
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2021-09-15 22:29:23 UTC
(In reply to Daniel Engberg from comment #1)

The official release tarballs differ in that they do not ship the testsuite.  While the test suite is not currently hooked up or installed, it might be interesting to do so in a future update.  And there's no point in changing to a different release tarball and then later back.
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2021-09-15 22:43:11 UTC
Actually scratch that.  The testsuite is in .gitattributes as “export-ignore” so it is not in the github provided tarball.  The two actually have character by character identical files.  So no point in changing that either.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-29 00:52:56 UTC
(In reply to Robert Clausecker from comment #2)
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-29 00:53:59 UTC
Multiple bugfix and security releases
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2021-09-30 13:43:14 UTC
Maintainer timeout.
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2021-09-30 13:43:48 UTC
Comment on attachment 227906 [details]
textproc/htmldoc: update to 1.9.12

Maintainer timeout
Comment 8 Robert Clausecker freebsd_committer freebsd_triage 2021-10-08 00:17:07 UTC
Comment on attachment 227906 [details]
textproc/htmldoc: update to 1.9.12

implicit approval by maintainer timeout
Comment 9 Piotr Kubaj freebsd_committer freebsd_triage 2021-10-08 01:27:39 UTC
ok on powerpc64le.
Comment 10 Jose Fernandes 2021-10-11 17:27:40 UTC
ok
Comment 11 Robert Clausecker freebsd_committer freebsd_triage 2021-10-11 17:34:03 UTC
(In reply to Jose Fernandes from comment #10)

Are you still interested in maintaining this port?  If yes you will of course stay maintainer.
Comment 12 Robert Clausecker freebsd_committer freebsd_triage 2021-10-14 11:25:16 UTC
All relevant QA (test on ppc64le) has been performed.  Remove needs-qa.
Comment 13 commit-hook freebsd_committer freebsd_triage 2021-10-14 19:55:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc703bd694e830e33dcdc3b371648e3d8920e859

commit dc703bd694e830e33dcdc3b371648e3d8920e859
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2021-10-14 19:34:43 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2021-10-14 19:50:37 +0000

    textproc/htmldoc: Update to 1.9.12 +

    - fix line break in USES that lead to wrong X11 usage
    - make USE=jpeg unconditional because it is needed even if HTMLDOCGUI
      is off
    - make pkgconfig unconditional because it is needed even if
      gnutls is not used
    - remove arm64 pre-build as it doesn't seem to be needed (perhaps
      ndowens knows more; he added it)
    - remove a PPC patch by pkubaj as it no longer required
    - apply formatting fixes from linters (portclippy, portfmt, portlint)

    Changelogs:

    https://www.msweet.org/blog/2021-05-17-htmldoc-1.9.12.html
    https://www.msweet.org/blog/2020-12-24-htmldoc-1.9.11.html
    https://www.msweet.org/blog/2020-09-05-htmldoc-1.9.10.html
    https://www.msweet.org/blog/2020-06-11-htmldoc-1.9.9.html
    https://www.msweet.org/blog/2020-02-15-htmldoc-1.9.8.html
    https://www.msweet.org/blog/2019-10-09-htmldoc-1.9.7.html
    https://www.msweet.org/blog/2019-09-25-htmldoc-1.9.6.html
    https://www.msweet.org/blog/2019-01-23-htmldoc-1.9.5.html
    https://www.msweet.org/blog/2018-08-31-htmldoc-1.9.4.html

    PR:             258507
    Approved by:    jose@diasfernandes.pt (maintainer)

 textproc/htmldoc/Makefile                         | 35 +++++++++--------------
 textproc/htmldoc/distinfo                         |  6 ++--
 textproc/htmldoc/files/patch-png_pngpriv.h (gone) | 14 ---------
 3 files changed, 16 insertions(+), 39 deletions(-)