Bug 258565 - security/clamav: Update to 0.104.0
Summary: security/clamav: Update to 0.104.0
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL: https://blog.clamav.net/2021/09/clama...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-18 06:57 UTC by Yasuhiro Kimura
Modified: 2021-09-29 13:09 UTC (History)
4 users (show)

See Also:


Attachments
Patch file (29.22 KB, patch)
2021-09-18 06:57 UTC, Yasuhiro Kimura
yasu: maintainer-approval+
Details | Diff
Updated patch file (29.27 KB, patch)
2021-09-18 10:37 UTC, Yasuhiro Kimura
yasu: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer 2021-09-18 06:57:25 UTC
Created attachment 227970 [details]
Patch file

* Update to 0.104.0.
* Update COMMENT and pkg-descr.

Release Notes: https://blog.clamav.net/2021/09/clamav-01040-released.html
Comment 1 Yasuhiro Kimura freebsd_committer 2021-09-18 10:37:57 UTC
Created attachment 227976 [details]
Updated patch file

* Add "(Regular (non-LTS) version)" to COMMENT to make it clear this is non-LTS version compared with upcoming security/clamav-lts.
* Pet portclippy
Comment 2 Koichiro Iwao freebsd_committer 2021-09-29 09:06:33 UTC
Assign to submitter since submitter is now commiitter.
Comment 3 Daniel Engberg freebsd_committer 2021-09-29 13:09:30 UTC
Looks good!

A few suggestions on improvements

Do we still need INSTALL_TARGET?

Instead of the OPT_CMAKE_ON/OFF doesn't OPT_CMAKE_BOOL work?
https://docs.freebsd.org/en/books/porters-handbook/book/#options-cmake_bool

MILTER_CFLAGS/LDFLAGS --> USES= localbase
https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk

L68 (new patch) MILTER should probably be better defined rather than "if exists" (base vs port)
L69 --> += should be =

L80 should probably be python:3.6+,test (unless 2.X still works)
https://cgit.freebsd.org/ports/tree/Mk/Uses/python.mk#n38

118 --> TEST_TARGET= check ?

You might want to put docs path in lowercase for consistency

Best regards,
Daniel