Bug 258594 - [NEW PORT] databases/keydb: Key-value storage, SMP-enabled redis fork
Summary: [NEW PORT] databases/keydb: Key-value storage, SMP-enabled redis fork
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/EQ-Alpha/KeyDB
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-09-19 07:40 UTC by Eugene M. Zheganin
Modified: 2021-09-20 00:48 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (eugene)


Attachments
databases/keydb shar archive (9.21 KB, application/x-shellscript)
2021-09-19 07:40 UTC, Eugene M. Zheganin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene M. Zheganin 2021-09-19 07:40:35 UTC
Created attachment 228002 [details]
databases/keydb shar archive

New port - databases/keydb.
Upstream: https://github.com/EQ-Alpha/KeyDB

What is all about: keydb is an SMP-enabled redis fork (we use it on Linux in a production environment, I want to use it on FreeBSD as well).

portlint sequence:

===Cut===
[root@dev:ports/databases]# portlint -ACN /usr/ports/databases/keydb
WARN: Makefile: possible use of absolute pathname "/var/db/keydb".
WARN: Makefile: possible use of absolute pathname "/var/run/keydb".
WARN: Makefile: possible use of absolute pathname "/var/log/keydb".
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 6 warnings found.
===Cut===
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-20 00:48:31 UTC
Review items:

- Use USE_GITHUB for fetching tagged source code archives for distribution files. MASTER_SITES / DISTFILES / WRKSRC should then not be necessary

- += not required for USES (=)

- Group and Sort USES/USE_*

- TEST_TARGET=test should just work and not require a do-test (invoking GMAKE automatically)

- Does this conflict with any redis or redis related? Are CONFLICTS_* required, either for build, or install?

If you could also confirm this port passes QA (poudriere), that would be great. Logs are not necessary (set DEVELOPER=yes in /etc/make.conf for extra sanity checks)