Created attachment 228008 [details]
v1 (apply via "git am")
Looks good to me, after the exp-run.
Runtime OK here on 14-CURRENT/amd64 with leaf ports:
Please disable build of unit tests by default, we're working with upstream to fix at least one issue found running doing unit tests.
Exp-run looks fine
(In reply to Daniel Engberg from comment #3)
Some failing tests isn't good enough reason to hide all tests:
- poudriere doesn't run "make test", so it cannot block build even with PORTTESTING=1 + PORTTESTING_RECURSIVE=1
- glib:glib / unix is OK here
- 2.68.4 already had 6 failing tests here, and 2.70.0 has the same number
- 1 more test failure wouldn't be much worse
If shaving build time is important I'd rather do something like ports e011fe87582b which emulates USES=cmake:testing behavior. Even better would be to implement USES=meson:testing.
 3 of those are gdbus-related due to the test relying on autolaunch pandemonium instead of explicitly setting up a separate session bus via dbus-run-session.
A commit in branch main references this bug:
Author: Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-09-17 10:17:56 +0000
Commit: Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-09-27 17:09:05 +0000
devel/glib20: update to 2.70.0
Tested by: Evgeniy Khramtsov
Approved by: tcberner
devel/glib20/Makefile | 4 ++--
devel/glib20/distinfo | 6 +++---
devel/glib20/files/patch-glib_meson.build | 10 +++++-----
devel/glib20/pkg-plist | 2 ++
4 files changed, 12 insertions(+), 10 deletions(-)