Bug 258669 - net/rubygem-grpc130: fix deps to match definition upstream
Summary: net/rubygem-grpc130: fix deps to match definition upstream
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-21 18:50 UTC by Matthias Fechner
Modified: 2021-09-23 19:43 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Fix deps (1.68 KB, patch)
2021-09-21 18:50 UTC, Matthias Fechner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Fechner freebsd_committer 2021-09-21 18:50:16 UTC
Created attachment 228103 [details]
Fix deps

Is there a special reason why the dependency for google-protobuff was modified?

The rubygem lists ~> 3.12:
https://rubygems.org/gems/grpc/versions/1.30.2

If it is ok for you, I would commit it, after I finished testing the new gitlab 14.3.0 version.
Comment 1 Po-Chuan Hsieh freebsd_committer 2021-09-21 22:28:37 UTC
Hmm, you made those changes in [1] and [2] to avoid protobuf 3.15.
Anyway, feel free to fix it.

[1] https://cgit.freebsd.org/ports/commit/?id=073c1c710a0c7254820adab9920c1903ace83fae
[2] https://cgit.freebsd.org/ports/commit/?id=721f51f965ec88ce36e5c1205569fe37e2239bcc
Comment 2 Matthias Fechner freebsd_committer 2021-09-23 19:43:57 UTC
Version 1.30 of grpc does not work with Gitlab even if Gitlab is enforcing it.
Instead version 1.40 of grpc works fine with gitlab.

So I will not touch this port and will use rubygem-grpc 1.40 instead.