Bug 258706 - devel/llvm13: fails check-plist on aarch64
Summary: devel/llvm13: fails check-plist on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Only Me
Assignee: Brooks Davis
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2021-09-24 13:28 UTC by Jan Beich
Modified: 2021-09-29 17:56 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-09-24 13:28:05 UTC
$ poudriere testport -j 122aarch64 devel/llvm13
[...]
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx700.bc
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx701.bc
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx801.bc
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx803.bc
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx900.bc
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx902.bc
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx906.bc
Error: Orphaned: llvm13/lib/libomptarget-amdgcn-gfx908.bc
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
Comment 1 Brooks Davis freebsd_committer 2021-09-24 21:45:52 UTC
This is a bit of an oddity. The files in question are being build for aarch64 and maybe powerpc, but not amd64 because a pattens matches x86_64 and not amd64.  Given the supplied targets are wrong (e.g., powerpc64le-unknown-linux-gnu), I doubt the resulting files are useful.  I think the immediate solution is:

OPENMP_CMAKE_IN=       -DLIBOMPTARGET_BUILD_AMDGCN_BCLIB=OFF

I'll verify it isn't broken before I commit it, but I don't have an aarch64 box I can easily test it on so it may not do the trick.

Someone with the ability to test and debug these targets could probably turn them on easily enough, but that should probably go through upstream.
Comment 2 commit-hook freebsd_committer 2021-09-27 22:25:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=79207f500c9bf7daf9c1517d71f71b4a2950300f

commit 79207f500c9bf7daf9c1517d71f71b4a2950300f
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2021-09-27 22:23:57 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2021-09-27 22:23:57 +0000

    devel/llvm13: Disable OpenMP amdgcn bit code

    Due to a bug in the CMakefiles these build for aarch64 and maybe
    ppc64le.  This resulted in plist breakage for aarch64.

    It would be straightforward to enable them for amd64, but I have no way
    to test them and the current CMake bits build them for linux targets so
    I suspect they won't work.

    PR:             258706
    Reviewed by:    jbeich
    Sponsored by:   DARPA

 devel/llvm13/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 3 commit-hook freebsd_committer 2021-09-29 17:56:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=90c91e5530189942662fa703649f52e3061d85dc

commit 90c91e5530189942662fa703649f52e3061d85dc
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2021-09-29 17:53:16 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2021-09-29 17:55:58 +0000

    devel/llvm13: Disable OpenMP amdgcn bit code

    Fix a typo in 79207f500c9bf7daf9c1517d71f71b4a2950300f so it actually
    has an effect.

    PR:             258706
    Reported by:    pkubaj
    Sponsored by:   DARPA

 devel/llvm13/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)