Bug 258716 - x11-wm/fvwm3: update to 1.0.4
Summary: x11-wm/fvwm3: update to 1.0.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
Depends on:
Reported: 2021-09-25 10:54 UTC by Felix Palmen
Modified: 2021-09-26 00:24 UTC (History)
1 user (show)

See Also:

0001-x11-wm-fvwm3-update-to-1.0.4 (8.64 KB, patch)
2021-09-25 10:54 UTC, Felix Palmen
felix: maintainer-approval+
Details | Diff
0001-x11-wm-fvwm3-update-to-1.0.4 (8.64 KB, patch)
2021-09-25 13:06 UTC, Felix Palmen
no flags Details | Diff
0001-x11-wm-fvwm3-update-to-1.0.4 (8.64 KB, patch)
2021-09-25 13:10 UTC, Felix Palmen
felix: maintainer-approval+
Details | Diff
0001-x11-wm-fvwm3-update-to-1.0.4 (8.69 KB, patch)
2021-09-25 14:23 UTC, Felix Palmen
felix: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Palmen 2021-09-25 10:54:14 UTC
Created attachment 228166 [details]

New upstream release 1.0.4

Building FvwmPrompt written in Go now works, therefore added option GO to enable it. Disabling XFT and XSM seems broken, therefore removed these options for now.

Many options combinations tested with poudriere testport.

Attached patch applies with 'git am'.
Comment 1 Felix Palmen 2021-09-25 13:06:51 UTC
Created attachment 228171 [details]

After discussion with a few ppl, I think it's better to enable the new GO option by default. It only pulls in a build dependency (so, building the port yourself, you can disable it if you don't like). The FvwmPrompt binary is kind of large cause it links all the Go dependencies statically, but 2.5MB still isn't much nowadays. Given the usability improvement, it would be nice to have it in the official package.
Comment 2 Felix Palmen 2021-09-25 13:10:00 UTC
Created attachment 228172 [details]

And because I'm too stupid to use git correctly, here's the patch again.
Comment 3 Vanilla I. Shu freebsd_committer 2021-09-25 14:18:19 UTC
(In reply to Felix Palmen from comment #2)


according the changelog,

I think we should remove libbson from LIB_DEPENDS,

it replaced by cJSON as internal package.
Comment 4 Felix Palmen 2021-09-25 14:23:27 UTC
Created attachment 228174 [details]

(In reply to Vanilla I. Shu from comment #3)

Oops, I really missed that one, thanks a lot. Did a few quick build tests confirming this lib dep is indeed unnecessary now!
Comment 5 Vanilla I. Shu freebsd_committer 2021-09-26 00:23:34 UTC
Committed, thanks.
Comment 6 commit-hook freebsd_committer 2021-09-26 00:24:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5895b52f8e05e69ac82b6c1c828fc207a17f5a62

commit 5895b52f8e05e69ac82b6c1c828fc207a17f5a62
Author:     Vanilla I. Shu <vanilla@FreeBSD.org>
AuthorDate: 2021-09-26 00:18:37 +0000
Commit:     Vanilla I. Shu <vanilla@FreeBSD.org>
CommitDate: 2021-09-26 00:23:20 +0000

    x11-wm/fvwm3: update to 1.0.4.

    ChangeLog: https://github.com/fvwmorg/fvwm3/blob/1.0.4/CHANGELOG.md

    PR:             258716
    Reported by:    maintainer

 x11-wm/fvwm3/Makefile  | 34 +++++++++++-----------
 x11-wm/fvwm3/distinfo  |  6 ++--
 x11-wm/fvwm3/pkg-plist | 77 ++++++++++++++++++++++++--------------------------
 3 files changed, 56 insertions(+), 61 deletions(-)