Created attachment 228197 [details] Patch This patch adds a new port sysutils/cpufetch which is a simple CPU architecture fetching tool.
Created attachment 228198 [details] Poudriere testport log
Hi, L1 is obsolete (remove) Please read the Porter's Handbook about ports that uses USE_GITHUB https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-description (especially "Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX") L7 and L15 conflicts (don't invent your own release numbering) Use portlint to fix ordering within the Makefile https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-portlint Is gmake a hard requirement? USES should also be USES= not += unless you set options several times within the Makefile There's another utility already available that seems to do pretty much the same thing? Is this any different except for the text art? sysutils/cpu-x Thanks for your contribution!
Created attachment 228202 [details] Patch
Thank you for your comments. I've updated the patch accordingly. Yes, gmake is a hard requirement. Upstream's Makefile expects gmake. I agree that there is already a similar utility available. There are a couple of ports I want to contribute in the very near feature and this served as a first step. I intentionally picked a port that is easy to create with minimum hassles regarding dependencies to get familiar with the environment, tools & workflow.
Created attachment 228203 [details] Patch
Fair enough =) What I forgot to mention is that you can also specify PLIST_FILES within the Makefile instead of using pkg-plist although I would recommend against that approach unless there are really few files. https://docs.freebsd.org/en/books/porters-handbook/book/ --> 3.2.2. pkg-plist This will probably land some time next week but if you can feel free to convert pkg-plist to PLIST_FILES meanwhile. Best regards, Daniel
Created attachment 228211 [details] Path
Created attachment 228212 [details] Patch
I've updated the patch to use PLIST_FILES.
Can you add a ONLY_FOR_ARCHS_REASON please? I suppose it doesn't work on arm or ppc? why?
Alright, I'll do that! The reason is that upstream doesn't support PPC. Is there a convention for the reason? I.e. "upstream doesn't support" or something like that?
(In reply to Joel Bodenmann from comment #11) Yes you can add that 'upstream only support x86' or 'uses x86 asm' (I haven't looked at the code tbh)
Created attachment 228217 [details] Patch
As I am new to this I'm not sure whether you have received a notification when I uploaded the modified patch: I've added a ONLY_FOR_ARCHS_REASON as requested.
(In reply to Joel Bodenmann from comment #14) Yes I received a notification. Just to be picky, only_for_archs_reason is wrong, upstream supports also arm and powerpc, it's just that it's not ported to FreeBSD yet. No need to provide another patch, the committer can modify this information.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=6ab6d5d5164263fd838b41c7adc361eafe4d7379 commit 6ab6d5d5164263fd838b41c7adc361eafe4d7379 Author: Joel Bodenmann <joel@insane.engineer> AuthorDate: 2021-10-01 12:49:00 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2021-10-01 12:51:04 +0000 sysutils/cpufetch: Add new port. Simple yet fancy CPU architecture fetching tool. cpufetch is a command-line tool written in C that displays the CPU information in a clean and beautiful way. WWW: https://github.com/Dr-Noob/cpufetch PR: 258736 sysutils/Makefile | 1 + sysutils/cpufetch/Makefile (new) | 29 +++++++++++++++++++++++++++++ sysutils/cpufetch/distinfo (new) | 3 +++ sysutils/cpufetch/pkg-descr (new) | 6 ++++++ 4 files changed, 39 insertions(+)
GH_PROJECT isn't needed :-) 5.4.3 in Porters Handbook
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=45d06e32d851f9fdcfd4068aa843ba1616de48b8 commit 45d06e32d851f9fdcfd4068aa843ba1616de48b8 Author: Mikael Urankar <mikael@FreeBSD.org> AuthorDate: 2021-10-04 17:30:42 +0000 Commit: Mikael Urankar <mikael@FreeBSD.org> CommitDate: 2021-10-05 10:46:33 +0000 sysutils/cpufetch: remove unneeded GH_PROJECT PR: 258736 Reported by: diizzy sysutils/cpufetch/Makefile | 1 - 1 file changed, 1 deletion(-)